Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

frankvicky merged PR #19510: URL: https://github.com/apache/kafka/pull/19510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2912067260 Gentle reminder @frankvicky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2905502150 Thanks @mingyen066 and @Yunyung for the review I have added the suggestions. Please re-review -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

mingyen066 commented on code in PR #19510: URL: https://github.com/apache/kafka/pull/19510#discussion_r2104803460 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -9332,7 +9316,7 @@ class KafkaApisTest extends Logging { assertEquals(clusterId, describeClu

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

Yunyung commented on code in PR #19510: URL: https://github.com/apache/kafka/pull/19510#discussion_r2104824058 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -9332,7 +9316,7 @@ class KafkaApisTest extends Logging { assertEquals(clusterId, describeCluste

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

Yunyung commented on code in PR #19510: URL: https://github.com/apache/kafka/pull/19510#discussion_r2104824058 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -9332,7 +9316,7 @@ class KafkaApisTest extends Logging { assertEquals(clusterId, describeCluste

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2904026879 Thanks @frankvicky The build looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2903156409 Hey @chia7712 , Gentle reminder for the PR here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2817013444 Thanks @frankvicky Adding in the changes in a subsequent commit. Pls review when possible! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia commented on PR #19510: URL: https://github.com/apache/kafka/pull/19510#issuecomment-2815347384 Thanks @FrankYang0529 Adding in the changes you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] MINOR: Cleanup Core Module- Scala Modules (2/n) [kafka]

sjhajharia opened a new pull request, #19510: URL: https://github.com/apache/kafka/pull/19510 Now that Kafka Brokers support Java 17, this PR makes some changes in core module. The changes in this PR are limited to only the Scala files in the Core module's tests. The unit tests module i