JimmyWang6 commented on PR #20271:
URL: https://github.com/apache/kafka/pull/20271#issuecomment-3154836525
> Could you add test case for this behaviour?
Sure, thanks for your comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
TaiJuWu commented on PR #20271:
URL: https://github.com/apache/kafka/pull/20271#issuecomment-3139778617
Could you add test case for this behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JimmyWang6 opened a new pull request, #20271:
URL: https://github.com/apache/kafka/pull/20271
See ：[#20168 ](https://github.com/apache/kafka/pull/20168) and
[#20235](https://github.com/apache/kafka/pull/20235)
This PR applys partition leader check for `StreamsGroupCommand` to aviod
comm
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2230764127
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +155,29 @@ public void
testResetOffsetsNotExistingGroup(Cl
Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2230635080
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +155,29 @@ public void
testResetOffsetsNotExistingGroup(Cl
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2230581343
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(Cl
chia7712 commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2230496206
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(C
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2229453274
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,28 @@ public void
testResetOffsetsNotExistingGroup(Cl
chia7712 commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228948879
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,28 @@ public void
testResetOffsetsNotExistingGroup(C
Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228715330
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,30 @@ public void
testResetOffsetsNotExistingGroup(Cl
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228661633
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -653,7 +653,7 @@ private List
filterNoneLeaderPartitions(Collection
entr
Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228614978
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -653,7 +653,7 @@ private List
filterNoneLeaderPartitions(Collection
entr
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228543903
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(Cl
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228543903
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(Cl
Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228324106
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(Cl
Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228260726
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(Cl
Yunyung commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2228260726
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +154,26 @@ public void
testResetOffsetsNotExistingGroup(Cl
AndrewJSchofield commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227804943
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -1054,7 +1054,7 @@ private List
filterNonExistentPartitions(Coll
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227784143
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +158,33 @@ public void
testResetOffsetsNotExistingGroup(Cl
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227784143
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -153,6 +158,33 @@ public void
testResetOffsetsNotExistingGroup(Cl
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227774442
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -1054,7 +1054,7 @@ private List
filterNonExistentPartitions(Collection ne
AndrewJSchofield commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227745369
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -1054,7 +1054,7 @@ private List
filterNonExistentPartitions(Coll
TaiJuWu commented on code in PR #20235:
URL: https://github.com/apache/kafka/pull/20235#discussion_r2227774442
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -1054,7 +1054,7 @@ private List
filterNonExistentPartitions(Collection ne
TaiJuWu opened a new pull request, #20235:
URL: https://github.com/apache/kafka/pull/20235
See: https://github.com/apache/kafka/pull/20168#discussion_r2227310093
There is a topic having three partitions, and the `t-2` partition is
offline, then if partitionsToReset is` t-1`, filterNon
TaiJuWu closed pull request #18358: MINOR: KAFKA-18280 follow up
URL: https://github.com/apache/kafka/pull/18358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
github-actions[bot] commented on PR #18358:
URL: https://github.com/apache/kafka/pull/18358#issuecomment-2771264548
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
ijuma commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2701424539
I have some thoughts on this, will share them later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
chia7712 commented on PR #19107:
URL: https://github.com/apache/kafka/pull/19107#issuecomment-2701386610
@mingdaoy could you please tweak the title? maybe "MINOR: improve the
example of kafka-metadata-shell.sh"?
--
This is an automated message from the Apache Git Service.
To respond to th
mumrah commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2701364462
@mingdaoy please update your PR with trunk, you likely have a broken commit
in your history (which we just reverted).
--
This is an automated message from the Apache Git Service.
To resp
mingdaoy opened a new pull request, #19119:
URL: https://github.com/apache/kafka/pull/19119
https://github.com/apache/kafka/pull/19097#discussion_r1981526593
Result:
--
This is an autom
mingdaoy commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981564521
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ b
mingdaoy commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981577358
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ b
mingdaoy commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981564521
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ b
Yunyung commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981209854
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ bi
Yunyung commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981209854
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ bi
Yunyung commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981209854
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ bi
frankvicky commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981192398
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $
frankvicky commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981192398
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $
chia7712 commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981171909
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ b
mingdaoy opened a new pull request, #19107:
URL: https://github.com/apache/kafka/pull/19107
https://github.com/apache/kafka/pull/19103#issuecomment-2700303106
Fixed the snapshot file format:
mingdaoy commented on PR #19103:
URL: https://github.com/apache/kafka/pull/19103#issuecomment-2699747937
> @mingdaoy Have you addressed this [#19065
(comment)](https://github.com/apache/kafka/pull/19065#issuecomment-2698449640) ?
https://github.com/apache/kafka/pull/19065#issuecomment
mingdaoy opened a new pull request, #19103:
URL: https://github.com/apache/kafka/pull/19103
https://github.com/apache/kafka/pull/19065#issuecomment-2698614575
Fixed:
--
This is an a
mjsax commented on code in PR #18488:
URL: https://github.com/apache/kafka/pull/18488#discussion_r1917261628
##
docs/streams/developer-guide/processor-api.html:
##
@@ -67,42 +67,40 @@ OverviewCombining the DSL and the Processor
API:
You can combine the conv
mjsax commented on PR #18488:
URL: https://github.com/apache/kafka/pull/18488#issuecomment-2593826989
Merged to `trunk` and cherry-picked to `4.0` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
mjsax merged PR #18488:
URL: https://github.com/apache/kafka/pull/18488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #18488:
URL: https://github.com/apache/kafka/pull/18488#discussion_r1917260216
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java:
##
@@ -174,7 +174,7 @@ public S getStateStore(final String
name) {
mjsax commented on code in PR #18488:
URL: https://github.com/apache/kafka/pull/18488#discussion_r1917260216
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java:
##
@@ -174,7 +174,7 @@ public S getStateStore(final String
name) {
bbejeck commented on code in PR #18488:
URL: https://github.com/apache/kafka/pull/18488#discussion_r1916846438
##
docs/streams/developer-guide/processor-api.html:
##
@@ -67,42 +67,40 @@ OverviewCombining the DSL and the Processor
API:
You can combine the co
mjsax commented on code in PR #18488:
URL: https://github.com/apache/kafka/pull/18488#discussion_r1911784754
##
docs/streams/developer-guide/processor-api.html:
##
@@ -67,42 +67,40 @@ OverviewCombining the DSL and the Processor
API:
You can combine the conv
mjsax commented on code in PR #18488:
URL: https://github.com/apache/kafka/pull/18488#discussion_r1911785250
##
docs/streams/developer-guide/testing.html:
##
@@ -276,15 +276,15 @@
To begin with, instantiate your processor and initialize it
with t
mjsax opened a new pull request, #18488:
URL: https://github.com/apache/kafka/pull/18488
Docs and JavaDocs updates for 4.0 release KIPs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #14485:
URL: https://github.com/apache/kafka/pull/14485#issuecomment-2568654582
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #14485: MINOR: KAFKA-15526 followup
URL: https://github.com/apache/kafka/pull/14485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
TaiJuWu commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
TaiJuWu commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
TaiJuWu commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
TaiJuWu commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
TaiJuWu commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
ijuma commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899911671
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
TaiJuWu commented on PR #18358:
URL: https://github.com/apache/kafka/pull/18358#issuecomment-2566059958
@chia7712 @ijuma Could you take a look when you are available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
TaiJuWu opened a new pull request, #18358:
URL: https://github.com/apache/kafka/pull/18358
see https://github.com/apache/kafka/pull/18308#discussion_r1899834438
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test covera
github-actions[bot] closed pull request #9154: MINOR KAFKA-10382 - MockProducer
is not ThreadSafe, ideally it should be as the implementation it mocks is
URL: https://github.com/apache/kafka/pull/9154
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] commented on PR #9154:
URL: https://github.com/apache/kafka/pull/9154#issuecomment-2564157345
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] closed pull request #12907: MINOR: [KAFKA-14421] fix NPE
from OffsetFetchRequest toString
URL: https://github.com/apache/kafka/pull/12907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #12907:
URL: https://github.com/apache/kafka/pull/12907#issuecomment-2563279946
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
Yunyung commented on PR #17679:
URL: https://github.com/apache/kafka/pull/17679#issuecomment-2453693930
If there is a JIRA ticket, there's no need to add 'MINOR' in the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tedyyan opened a new pull request, #17679:
URL: https://github.com/apache/kafka/pull/17679
MINOR:
revise the Specifying test retries section, highlight the default value of
test retry parameters
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impl
mjsax commented on PR #15694:
URL: https://github.com/apache/kafka/pull/15694#issuecomment-2306058571
Thanks for the PR. Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mjsax merged PR #15694:
URL: https://github.com/apache/kafka/pull/15694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
github-actions[bot] commented on PR #15694:
URL: https://github.com/apache/kafka/pull/15694#issuecomment-2297941294
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
apoorvmittal10 commented on PR #16799:
URL: https://github.com/apache/kafka/pull/16799#issuecomment-2272876233
Yeah then let's get it merged with your changes. I am closing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
apoorvmittal10 closed pull request #16799: [MINOR] KAFKA-16741:Adding record
keys for share group (KIP-932)
URL: https://github.com/apache/kafka/pull/16799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AndrewJSchofield commented on PR #16799:
URL: https://github.com/apache/kafka/pull/16799#issuecomment-2270843876
> > @apoorvmittal10 We will have to coordinate with #16786.
>
> Agree, should I include others in this PR once PR #16786 is merged or we
merge this one and include other RP
apoorvmittal10 commented on PR #16799:
URL: https://github.com/apache/kafka/pull/16799#issuecomment-2270815908
> @apoorvmittal10 We will have to coordinate with #16786.
Agree, should I include others in this PR once PR #16786 is merged or we
merge this one and include other RPCs in #1
AndrewJSchofield commented on PR #16799:
URL: https://github.com/apache/kafka/pull/16799#issuecomment-2269821598
@apoorvmittal10 We will have to coordinate with
https://github.com/apache/kafka/pull/16786.
--
This is an automated message from the Apache Git Service.
To respond to the messa
apoorvmittal10 opened a new pull request, #16799:
URL: https://github.com/apache/kafka/pull/16799
Adding record keys for share groups.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
omkreddy merged PR #16261:
URL: https://github.com/apache/kafka/pull/16261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
VedarthConfluent commented on code in PR #16261:
URL: https://github.com/apache/kafka/pull/16261#discussion_r1632726769
##
docker/prepare_docker_official_image_source.py:
##
@@ -36,14 +36,18 @@
from distutils.dir_util import copy_tree
import os
import shutil
+import re
-d
VedarthConfluent commented on code in PR #16261:
URL: https://github.com/apache/kafka/pull/16261#discussion_r1632711348
##
docker/prepare_docker_official_image_source.py:
##
@@ -36,14 +36,18 @@
from distutils.dir_util import copy_tree
import os
import shutil
+import re
-d
KrishVora01 opened a new pull request, #16261:
URL: https://github.com/apache/kafka/pull/16261
This PR aims to add the replace the dockerfile comments under the
`jvm/dockerfile ` Dockerfile, with updated url.
The original comment read
`# Get kafka from https://archive.apache.org/dist/
mjsax merged PR #15517:
URL: https://github.com/apache/kafka/pull/15517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #15517:
URL: https://github.com/apache/kafka/pull/15517#discussion_r1523775722
##
docs/streams/developer-guide/config-streams.html:
##
@@ -97,6 +97,7 @@
Naming
Default Values
+ Default Values
cadonna commented on code in PR #15517:
URL: https://github.com/apache/kafka/pull/15517#discussion_r1522707185
##
docs/streams/developer-guide/config-streams.html:
##
@@ -97,6 +97,7 @@
Naming
Default Values
+ Default Value
mjsax opened a new pull request, #15517:
URL: https://github.com/apache/kafka/pull/15517
- add missing section to TOC
- add default value for client.id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #14485:
URL: https://github.com/apache/kafka/pull/14485#issuecomment-1903103104
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
IBeyondy opened a new pull request, #15069:
URL: https://github.com/apache/kafka/pull/15069
Found NullPointerException when executing
`testTruncateOnFetchDoesNotUpdateHighWatermark` in `ReplicaFetcherThreadTest`,
which is caused by lacking `ReplicaAlterLogDirsManager` mock for
`ReplicaMana
Alexander-Aghili opened a new pull request, #15055:
URL: https://github.com/apache/kafka/pull/15055
Split MetadataTest#testUpdateParitionLeadership into two tests:
MetadataTest#testIgnoreUpdatePartitionLeadership
MetadataTest#testApplyAndIgnoreUpdatesPartitionLeadership
Each test
splett2 commented on code in PR #14485:
URL: https://github.com/apache/kafka/pull/14485#discussion_r1368951497
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogAppendInfo.java:
##
@@ -204,6 +204,10 @@ public LeaderHwChange leaderHwChange() {
return lea
ijuma commented on code in PR #14485:
URL: https://github.com/apache/kafka/pull/14485#discussion_r1367946637
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogAppendInfo.java:
##
@@ -204,6 +204,10 @@ public LeaderHwChange leaderHwChange() {
return leade
lucasbru merged PR #14503:
URL: https://github.com/apache/kafka/pull/14503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #14503:
URL: https://github.com/apache/kafka/pull/14503#issuecomment-1761075787
Test failures unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
lucasbru commented on code in PR #14503:
URL: https://github.com/apache/kafka/pull/14503#discussion_r1357057172
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -322,6 +323,25 @@ public void testOffsetsForTimesOnNullPart
lianetm commented on PR #14503:
URL: https://github.com/apache/kafka/pull/14503#issuecomment-1759658605
hey @lucasbru, thanks a lot for all the comments, all addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
lianetm commented on code in PR #14503:
URL: https://github.com/apache/kafka/pull/14503#discussion_r1356866475
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -322,6 +323,25 @@ public void testOffsetsForTimesOnNullParti
lianetm commented on code in PR #14503:
URL: https://github.com/apache/kafka/pull/14503#discussion_r1356848021
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -235,15 +235,18 @@ public ConsumerRecords poll(final Duration ti
lucasbru commented on code in PR #14503:
URL: https://github.com/apache/kafka/pull/14503#discussion_r1356663540
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -322,6 +323,25 @@ public void testOffsetsForTimesOnNullPart
lucasbru commented on code in PR #14503:
URL: https://github.com/apache/kafka/pull/14503#discussion_r1356610621
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -252,8 +255,10 @@ private boolean updateFetchPositionsIfNeeded(
lianetm commented on PR #14503:
URL: https://github.com/apache/kafka/pull/14503#issuecomment-1756011144
hey @cadonna, @lucasbru. This is a very small PR adding a missing API
validation to the new consumer `offsetsForTimes` functionality.
It also includes some improved comments for the `
lianetm closed pull request #14503: MINOR - KAFKA-15550: Validation for
negative target times in offsetsForTimes
URL: https://github.com/apache/kafka/pull/14503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
lianetm opened a new pull request, #14503:
URL: https://github.com/apache/kafka/pull/14503
The current KafkaConsumer `offsetsForTimes` fails with
`IllegalArgumentException` if negative target timestamps are provided as
arguments. This PR includes the same validation and tests for the new co
1 - 100 of 104 matches
Mail list logo
