rajinisivaram merged PR #13277:
URL: https://github.com/apache/kafka/pull/13277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
rajinisivaram commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2163778250
@ivanyu Thanks for the updates, test failures not related, merging to trunk
and 3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ivanyu commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2163515422
Some tests are failing on one pipeline, but they seem unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1636356455
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1121,13 +1140,25 @@ public long maybeUpdate(long now) {
// Beware that the be
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1636337120
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1121,13 +1140,25 @@ public long maybeUpdate(long now) {
// Beware that the be
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1636332264
##
clients/src/main/java/org/apache/kafka/clients/LeastLoadedNode.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
rajinisivaram commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1635927735
##
clients/src/main/java/org/apache/kafka/clients/LeastLoadedNode.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
rajinisivaram commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2162268137
@ivanyu There are more test failures that need fixing before this PR can be
merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ivanyu commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2161302594
Comments addressed and conflicts resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1635256179
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -705,16 +715,25 @@ public Node leastLoadedNode(long now) {
Node foundCanConnect = nu
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1635231090
##
clients/src/main/java/org/apache/kafka/clients/LeastLoadedNode.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1635230739
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1122,13 +1141,26 @@ public long maybeUpdate(long now) {
// Beware that the be
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1635197250
##
server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java:
##
@@ -75,6 +75,10 @@ public class ServerConfigs {
public static final long SOCKET_CONNEC
rajinisivaram commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2158922004
@ivanyu Also need to fix unit tests that are failing because of the change
from Node to LeastLoadedNode and resolve merge conflicts.
--
This is an automated message from the Apach
rajinisivaram commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1633579132
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1122,13 +1141,26 @@ public long maybeUpdate(long now) {
// Beware that
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1623777938
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1123,6 +1133,17 @@ public long maybeUpdate(long now) {
// Beware that the behav
rajinisivaram commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1622186108
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -304,6 +306,12 @@ public synchronized void bootstrap(List
addresses) {
this.needF
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620696831
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1123,6 +1133,17 @@ public long maybeUpdate(long now) {
// Beware that the behav
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620593527
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java:
##
@@ -287,4 +293,12 @@ public void update(Cluster cluster, long now) {
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620581608
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -135,6 +136,7 @@ object KafkaConfig {
.define(ServerConfigs.REQUEST_TIMEOUT_MS_CONFIG, INT,
ServerCo
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620553331
##
clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620549218
##
clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620547544
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -307,7 +307,8 @@ class KafkaRaftManager[T](
time,
discoverBrokerVersions,
apiVersions,
-
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620545307
##
clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620547544
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -307,7 +307,8 @@ class KafkaRaftManager[T](
time,
discoverBrokerVersions,
apiVersions,
-
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1620514653
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -304,6 +306,12 @@ public synchronized void bootstrap(List
addresses) {
this.needFullUpda
gharris1727 commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1619177795
##
clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rajinisivaram commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1619159464
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -1123,6 +1133,17 @@ public long maybeUpdate(long now) {
// Beware that th
ivanyu commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2137695965
I see there are some failures in the rebootstrap tests on CI. I need to deal
with them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ivanyu commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2136891093
> I noticed there isn't an AdminClientReboostrapTest, is that intentional? I
wouldn't personally require one because the change is in NetworkClient and not
the admin client specifically, b
ivanyu commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2135867575
Yep, doing this + finishing with the admin client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gharris1727 commented on PR #13277:
URL: https://github.com/apache/kafka/pull/13277#issuecomment-2135860640
Hi @ivanyu Could you resolve the merge conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1616295494
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -219,6 +219,19 @@ public class CommonClientConfigs {
public static final String DE
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1616292083
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
Review Comment:
Thank you. I removed extra constructors in this case
--
This is an auto
gharris1727 commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1610617003
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -219,6 +219,19 @@ public class CommonClientConfigs {
public static final Stri
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1607019116
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
Review Comment:
I added a number of constructors here instead of altering the existing
bec
36 matches
Mail list logo
