Re: [PR] KAFKA-4650: Add unit tests for GraphNode class [kafka]

2025-05-21 Thread via GitHub
bbejeck commented on PR #18951: URL: https://github.com/apache/kafka/pull/18951#issuecomment-2897893435 Thanks for the contribution @lorcanj ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-4650: Add unit tests for GraphNode class [kafka]

2025-05-21 Thread via GitHub
bbejeck commented on PR #18951: URL: https://github.com/apache/kafka/pull/18951#issuecomment-2897882620 merged #18951 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-4650: Add unit tests for GraphNode class [kafka]

2025-05-21 Thread via GitHub
bbejeck merged PR #18951: URL: https://github.com/apache/kafka/pull/18951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-4650: Add unit tests for GraphNode class [kafka]

2025-05-17 Thread via GitHub
lorcanj commented on PR #18951: URL: https://github.com/apache/kafka/pull/18951#issuecomment-2888291189 Hi @bbejeck, I've removed the merge commit and rebased the PR instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-4650: Add unit tests for GraphNode class [kafka]

2025-03-13 Thread via GitHub
lorcanj commented on PR #18951: URL: https://github.com/apache/kafka/pull/18951#issuecomment-2721323459 Hi @mjsax, just messaging again regarding a review when you can take a look. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-4650: Add unit tests for GraphNode class [kafka]

2025-02-24 Thread via GitHub
lorcanj commented on PR #18951: URL: https://github.com/apache/kafka/pull/18951#issuecomment-2679461678 Hi @mjsax, I've updated the formatting of the test file due to the build failure that occurred due to this. After pushing these changes there was an error with QuorumControllerTest,