Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-30 Thread via GitHub
apoorvmittal10 merged PR #19846: URL: https://github.com/apache/kafka/pull/19846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-29 Thread via GitHub
DL1231 commented on code in PR #19846: URL: https://github.com/apache/kafka/pull/19846#discussion_r2113951640 ## core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala: ## @@ -233,16 +234,16 @@ class DelayedRemoteFetchTest { private def buildReadResult(erro

Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-29 Thread via GitHub
apoorvmittal10 commented on code in PR #19846: URL: https://github.com/apache/kafka/pull/19846#discussion_r2113903699 ## core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala: ## @@ -233,16 +234,16 @@ class DelayedRemoteFetchTest { private def buildReadRes

Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-29 Thread via GitHub
DL1231 commented on code in PR #19846: URL: https://github.com/apache/kafka/pull/19846#discussion_r2113544999 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -849,9 +849,9 @@ private void completeRemoteStorageShareFetchRequest() {

Re: [PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-29 Thread via GitHub
apoorvmittal10 commented on code in PR #19846: URL: https://github.com/apache/kafka/pull/19846#discussion_r2113498469 ## server/src/main/java/org/apache/kafka/server/LogReadResult.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[PR] KAFKA-19346: Move LogReadResult to server module [kafka]

2025-05-28 Thread via GitHub
DL1231 opened a new pull request, #19846: URL: https://github.com/apache/kafka/pull/19846 1. Move `LogReadResult` to server module. 2. Rewrite `LogReadResult` in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use