Re: [PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-06-28 Thread via GitHub
FrankYang0529 commented on code in PR #19817: URL: https://github.com/apache/kafka/pull/19817#discussion_r2173166538 ## shell/src/main/java/org/apache/kafka/shell/MetadataShell.java: ## @@ -114,7 +114,7 @@ static FileLock takeDirectoryLock(File directory) throws IOException {

Re: [PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-06-08 Thread via GitHub
frankvicky commented on PR #19817: URL: https://github.com/apache/kafka/pull/19817#issuecomment-2954625380 Cherry pick to 3.9 and 4.0 branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-06-08 Thread via GitHub
frankvicky commented on PR #19817: URL: https://github.com/apache/kafka/pull/19817#issuecomment-2954594512 I have merged it. Feel free to raise issues if there are any. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-06-08 Thread via GitHub
frankvicky merged PR #19817: URL: https://github.com/apache/kafka/pull/19817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-05-26 Thread via GitHub
frankvicky commented on PR #19817: URL: https://github.com/apache/kafka/pull/19817#issuecomment-2911237948 @cmccabe: Could you please take a look when you have a free moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-05-26 Thread via GitHub
ocadaruma opened a new pull request, #19817: URL: https://github.com/apache/kafka/pull/19817 ## Summary - MetadataShell may deletes lock file unintentionally when it exists or fails to acquire lock. If there's running server, this causes unexpected result as below: * MetadataShell s