chirag-wadhwa5 commented on PR #19637:
URL: https://github.com/apache/kafka/pull/19637#issuecomment-2876988834
This PR is obsolete now. This task is now being handled in the PR ->
https://github.com/apache/kafka/pull/19701
Will close this PR
--
This is an automated message from the Apa
chirag-wadhwa5 closed pull request #19637: KAFKA-19231: Handle fetch request
when share session cache is full
URL: https://github.com/apache/kafka/pull/19637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chirag-wadhwa5 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2078441931
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6380,6 +6380,42 @@ class KafkaApisTest extends Logging {
assertEquals(0,
topicResponse
chirag-wadhwa5 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2078447273
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3049,6 +3049,11 @@ class KafkaApis(val requestChannel: RequestChannel,
// Creating the shareFe
apoorvmittal10 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2077391535
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6380,6 +6380,42 @@ class KafkaApisTest extends Logging {
assertEquals(0,
topicResponse
apoorvmittal10 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2077390465
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3049,6 +3049,11 @@ class KafkaApis(val requestChannel: RequestChannel,
// Creating the shareFe
chirag-wadhwa5 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2077345638
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6380,6 +6380,42 @@ class KafkaApisTest extends Logging {
assertEquals(0,
topicResponse
chirag-wadhwa5 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2077341351
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3049,6 +3049,11 @@ class KafkaApis(val requestChannel: RequestChannel,
// Creating the shareFe
apoorvmittal10 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2075641438
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6380,6 +6380,42 @@ class KafkaApisTest extends Logging {
assertEquals(0,
topicResponse
chirag-wadhwa5 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2075168617
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -2049,10 +2049,11 @@ class ShareFetchAcknowledgeRequestTest(cluster:
Clus
chirag-wadhwa5 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2075168617
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -2049,10 +2049,11 @@ class ShareFetchAcknowledgeRequestTest(cluster:
Clus
AndrewJSchofield commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2074999022
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3049,6 +3049,13 @@ class KafkaApis(val requestChannel: RequestChannel,
// Creating the share
apoorvmittal10 commented on code in PR #19637:
URL: https://github.com/apache/kafka/pull/19637#discussion_r2074232073
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -2049,10 +2049,11 @@ class ShareFetchAcknowledgeRequestTest(cluster:
Clus
chirag-wadhwa5 opened a new pull request, #19637:
URL: https://github.com/apache/kafka/pull/19637
According to the recent changes in KIP-932, when the share session cache is
full and a broker receives a Share Fetch request with Initial Share Session
Epoch (0), then the error code `SHARE_SES
14 matches
Mail list logo
