mumrah merged PR #19242:
URL: https://github.com/apache/kafka/pull/19242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2743356688
> btw, do you plan to set PR Linter as blocker?
Eventually, yes. We'll want it to be a required check before we switch on
the merge queue.
> would it be feasible to extend it
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2743749389
@ijuma I don't think GH will truncate the commit subject, but I'm not sure
-- I'll try it out on the sandbox repo.
It is _really_ annoying that we can't tweak the commit message with
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2752805699
I started a DISCUSS thread about this cc @ijuma @dajac @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2752507990
@dajac yes that's right. We can see that GH happily breaks existing trailers
with it's auto-reformatting
https://github.com/apache/kafka-merge-queue-sandbox/commit/27183691c299612a6f3d50a8
dajac commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2750756701
@mumrah I have noticed that it also breaks the `Reviewers` line. This will
make listing commits reviewed by someone harder, doesn't it? I wonder whether
we should also switch to using `Revi
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2741300567
@ijuma GitHub _does_ reformat the PR body when turning it into a commit
message. The reason I'd like to preemptively reformat PRs is so we don't have
surprises with our formatting.
ijuma commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2743458057
One advantage of leaving it to github is that the PR message itself isn't
limited to the shorter line length. Pretty sad that GitHub doesn't do a good
enough job. :(
--
This is an automa
chia7712 commented on code in PR #19242:
URL: https://github.com/apache/kafka/pull/19242#discussion_r2007419408
##
.github/scripts/pr-format.py:
##
@@ -132,6 +152,32 @@ def check(positive_assertion, ok_msg, err_msg):
check("Delete this text and replace" not in body, "PR tem
ijuma commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2740272180
Did we check that GitHub doesn't do this automatically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2737080357
To test this out, checkout the PR and run the following:
```
PR_NUMBER=19071 python .github/scripts/pr-format.py
```
⚠️ Do not run with GITHUB_ACTIONS set, or it will act
mumrah opened a new pull request, #19242:
URL: https://github.com/apache/kafka/pull/19242
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some comme
12 matches
Mail list logo
