mumrah merged PR #19168:
URL: https://github.com/apache/kafka/pull/19168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1987459608
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,30 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
+t
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1988290418
##
committer-tools/reviewers.py:
##
@@ -35,6 +39,41 @@ def prompt_for_user():
return clean_input
+def update_trailers(body, trailer):
+with temp
mumrah commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1987435500
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,30 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
Revie
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1987602902
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,30 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
+
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1987597807
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,30 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
R
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1988295503
##
committer-tools/reviewers.py:
##
@@ -35,6 +39,41 @@ def prompt_for_user():
return clean_input
+def update_trailers(body, trailer):
+with temp
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1988296755
##
committer-tools/reviewers.py:
##
@@ -87,9 +126,11 @@ def prompt_for_user():
continue
if selected_reviewers:
-out = "\n\nReviewers: "
-
mumrah commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1988246558
##
committer-tools/reviewers.py:
##
@@ -35,6 +39,41 @@ def prompt_for_user():
return clean_input
+def update_trailers(body, trailer):
+with tempfile
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1987798872
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,30 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
+
mingyen066 commented on PR #19168:
URL: https://github.com/apache/kafka/pull/19168#issuecomment-2711466211
@mumrah Thanks for reviewing. Make modifications based on the comments. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1987597807
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,30 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
R
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1986334149
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,31 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
+
chia7712 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1986329085
##
committer-tools/reviewers.py:
##
@@ -35,6 +37,31 @@ def prompt_for_user():
return clean_input
+def append_message_to_pr_body(pr_url, message):
+
mingyen066 commented on PR #19168:
URL: https://github.com/apache/kafka/pull/19168#issuecomment-2708858624
@chia7712 Fixed by adding another escape(two backslash) for python. It's
weired that one backslash is working fine in mac.
--
This is an automated message from the Apache Git Service
chia7712 commented on PR #19168:
URL: https://github.com/apache/kafka/pull/19168#issuecomment-2708854016
@mingyen066 could you please take a look at following error?
```
chia7712@chia7712-ubuntu:~/project/kafka$ ./committer-tools/reviewers.py
/home/chia7712/project/kafka/./committer
mingyen066 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1986320862
##
committer-tools/reviewers.py:
##
@@ -87,9 +112,16 @@ def prompt_for_user():
continue
if selected_reviewers:
-out = "\n\nReviewers: "
-
chia7712 commented on code in PR #19168:
URL: https://github.com/apache/kafka/pull/19168#discussion_r1986315184
##
committer-tools/reviewers.py:
##
@@ -87,9 +112,16 @@ def prompt_for_user():
continue
if selected_reviewers:
-out = "\n\nReviewers: "
-
mingyen066 opened a new pull request, #19168:
URL: https://github.com/apache/kafka/pull/19168
Enhance `reviewers.py` to append reviewer message to the PR body.
Add a comfirmation propmt to prevent human errors.
--
This is an automated message from the Apache Git Service.
To respond
19 matches
Mail list logo
