Re: [PR] KAFKA-18933 Extract an interface from ClusterInstance [kafka]

2025-03-11 Thread via GitHub
mumrah commented on PR #18697: URL: https://github.com/apache/kafka/pull/18697#issuecomment-2704928846 Closing in favor of #19144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-18933 Extract an interface from ClusterInstance [kafka]

2025-03-11 Thread via GitHub
mumrah closed pull request #18697: KAFKA-18933 Extract an interface from ClusterInstance URL: https://github.com/apache/kafka/pull/18697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-18933 Extract an interface from ClusterInstance [kafka]

2025-03-09 Thread via GitHub
ijuma commented on PR #18697: URL: https://github.com/apache/kafka/pull/18697#issuecomment-2709277315 @mumrah A bit hard to comment without understanding the goal. Is the goal to move client integration tests outside of `core`? -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-18933 Extract an interface from ClusterInstance [kafka]

2025-03-06 Thread via GitHub
mumrah commented on PR #18697: URL: https://github.com/apache/kafka/pull/18697#issuecomment-2704705840 Actually, I think this won't work. Even if we clean out server-common dependencies from test-common-internal-api, the clients module (and other Java 11 modules) can't bring in test-common-