Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-22 Thread via GitHub
johnny94 commented on PR #19306: URL: https://github.com/apache/kafka/pull/19306#issuecomment-2820420761 @chia7712 Thanks. Fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-17 Thread via GitHub
chia7712 commented on PR #19306: URL: https://github.com/apache/kafka/pull/19306#issuecomment-2813470200 @johnny94 could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-10 Thread via GitHub
johnny94 commented on code in PR #19306: URL: https://github.com/apache/kafka/pull/19306#discussion_r2038879355 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -284,7 +294,7 @@ public String hmac() { public void checkArgs() {

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-10 Thread via GitHub
johnny94 commented on code in PR #19306: URL: https://github.com/apache/kafka/pull/19306#discussion_r2038879355 ## tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java: ## @@ -284,7 +294,7 @@ public String hmac() { public void checkArgs() {

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-09 Thread via GitHub
FrankYang0529 commented on code in PR #19306: URL: https://github.com/apache/kafka/pull/19306#discussion_r2034706560 ## tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java: ## @@ -81,6 +92,27 @@ public void testDelegationTokenRequests() throws ExecutionEx

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-09 Thread via GitHub
FrankYang0529 commented on PR #19306: URL: https://github.com/apache/kafka/pull/19306#issuecomment-2788676789 BTW, could you add some content to PR description? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-04-04 Thread via GitHub
github-actions[bot] commented on PR #19306: URL: https://github.com/apache/kafka/pull/19306#issuecomment-2780168709 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] KAFKA-18870 Implement describeDelegationToken for controller [kafka]

2025-03-28 Thread via GitHub
johnny94 opened a new pull request, #19306: URL: https://github.com/apache/kafka/pull/19306 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m