chia7712 merged PR #19920:
URL: https://github.com/apache/kafka/pull/19920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
github-actions[bot] commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-3006945112
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
apalan60 commented on code in PR #19920:
URL: https://github.com/apache/kafka/pull/19920#discussion_r2164583324
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -47,6 +49,11 @@ public void setup() {
time = new MockTime(0, INITIAL
chia7712 commented on code in PR #19920:
URL: https://github.com/apache/kafka/pull/19920#discussion_r2157497344
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -47,6 +49,11 @@ public void setup() {
time = new MockTime(0, INITIAL
apalan60 commented on PR #19920:
URL: https://github.com/apache/kafka/pull/19920#issuecomment-2956146626
I ran a few more test classes that use logging with the command below. They
all passed successfully when executed in the same JVM.
```
/gradlew cleanTest \
-- :connect:ru
apalan60 commented on code in PR #19920:
URL: https://github.com/apache/kafka/pull/19920#discussion_r2134771638
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -41,12 +45,19 @@ public class LoggersTest {
private static final long IN
apalan60 commented on code in PR #19920:
URL: https://github.com/apache/kafka/pull/19920#discussion_r2134771638
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -41,12 +45,19 @@ public class LoggersTest {
private static final long IN
chia7712 commented on code in PR #19920:
URL: https://github.com/apache/kafka/pull/19920#discussion_r2134723614
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -41,12 +45,19 @@ public class LoggersTest {
private static final long IN
apalan60 commented on PR #19920:
URL: https://github.com/apache/kafka/pull/19920#issuecomment-2952528907
Verified that this change resolves the issue by running the following
command:
```bash
./gradlew cleanTest \
connect:runtime:test \
--tests LoggersTest.testSetLevelWit
apalan60 opened a new pull request, #19920:
URL: https://github.com/apache/kafka/pull/19920
Jira: [KAFKA-18834](https://issues.apache.org/jira/browse/KAFKA-18834)
- Flaky behavior
`LoggingResourceTest#testSetLevelDefaultScope` sometimes fails by not
capturing its expected WARN lo
chia7712 commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669973567
Another way is to reset the log level in
`testSetLevelWithValidRootLoggerNames`. It changes "all" loggers, so it may
impact other tests too.
--
This is an automated message from the A
chia7712 commented on code in PR #18972:
URL: https://github.com/apache/kafka/pull/18972#discussion_r1962485553
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResourceTest.java:
##
@@ -113,7 +113,7 @@ public void setLevelWithInvalidArgTes
chia7712 commented on PR #18972:
URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669837799
Personally, I prefer to adjust the level for the testSetLevelDefaultScope.
Please see my comment on the jira
--
This is an automated message from the Apache Git Service.
To respond to
13 matches
Mail list logo
