Re: [PR] KAFKA-18827: Initialize share state, share coordinator impl. [1/N] [kafka]

2025-02-22 Thread via GitHub
AndrewJSchofield merged PR #18968: URL: https://github.com/apache/kafka/pull/18968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18827: Initialize share state, share coordinator impl. [1/N] [kafka]

2025-02-21 Thread via GitHub
smjn commented on code in PR #18968: URL: https://github.com/apache/kafka/pull/18968#discussion_r1965713746 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -317,16 +319,12 @@ public CoordinatorResult wr Coordina

Re: [PR] KAFKA-18827: Initialize share state, share coordinator impl. [1/N] [kafka]

2025-02-21 Thread via GitHub
smjn commented on code in PR #18968: URL: https://github.com/apache/kafka/pull/18968#discussion_r1965706156 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -317,16 +319,12 @@ public CoordinatorResult wr Coordina

Re: [PR] KAFKA-18827: Initialize share state, share coordinator impl. [1/N] [kafka]

2025-02-21 Thread via GitHub
smjn commented on code in PR #18968: URL: https://github.com/apache/kafka/pull/18968#discussion_r1965706156 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -317,16 +319,12 @@ public CoordinatorResult wr Coordina

Re: [PR] KAFKA-18827: Initialize share state, share coordinator impl. [1/N] [kafka]

2025-02-21 Thread via GitHub
AndrewJSchofield commented on code in PR #18968: URL: https://github.com/apache/kafka/pull/18968#discussion_r1965580105 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -317,16 +319,12 @@ public CoordinatorResult wr