Re: [PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
dajac merged PR #18934: URL: https://github.com/apache/kafka/pull/18934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
dajac commented on code in PR #18934: URL: https://github.com/apache/kafka/pull/18934#discussion_r1958527263 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeMetrics.java: ## @@ -71,7 +71,7 @@ public interface CoordinatorRuntimeMe

Re: [PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
squah-confluent commented on code in PR #18934: URL: https://github.com/apache/kafka/pull/18934#discussion_r1958519491 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeMetrics.java: ## @@ -71,7 +71,7 @@ public interface Coordinato

[PR] KAFKA-18807; Fix thread idle ratio metric [kafka]

2025-02-17 Thread via GitHub
squah-confluent opened a new pull request, #18934: URL: https://github.com/apache/kafka/pull/18934 When group.coordinator.threads is greater than 1, we lose track of thread idle time because of integer arithmetic. Use doubles instead. ### Committer Checklist (excluded from commit me