Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

chia7712 merged PR #18802: URL: https://github.com/apache/kafka/pull/18802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on PR #18802: URL: https://github.com/apache/kafka/pull/18802#issuecomment-2699292282 Hi @chia7712, I addressed all comments. Could you review again when you have time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973100776 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

chia7712 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973092684 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973058360 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

chia7712 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973051360 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1968651186 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

chia7712 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1968431712 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1967345845 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1967122068 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

chia7712 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1967123214 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

chia7712 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1966864426 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -373,7 +373,7 @@ class ControllerServer( config.nodeId, sharedServer.metadataPublis

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1948343182 ## core/src/main/scala/kafka/server/metadata/AclPublisher.scala: ## @@ -1,102 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

clolov commented on PR #18802: URL: https://github.com/apache/kafka/pull/18802#issuecomment-2640289128 Heya @FrankYang0529! Okay, I cannot really find some paper trace explaining the reasoning of where we are putting publishers. Let's stick to what you originally proposed and leave things

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

clolov commented on PR #18802: URL: https://github.com/apache/kafka/pull/18802#issuecomment-2636838398 I am happy with putting everything under `org.apache.kafka.image.publisher` unless somebody else has a stronger preference about it 😊 -- This is an automated message from the Apache Git

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 commented on PR #18802: URL: https://github.com/apache/kafka/pull/18802#issuecomment-2636538131 > is there a reason you are defining a new one like `package org.apache.kafka.metadata.publisher`? Good point! There is another class `FeaturesPublisher` in `org.apache.kafka

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

clolov commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1942665622 ## core/src/main/scala/kafka/server/metadata/AclPublisher.scala: ## @@ -1,102 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one or more - * con

[PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

FrankYang0529 opened a new pull request, #18802: URL: https://github.com/apache/kafka/pull/18802 Move `AclPublisher` to `org.apache.kafka.metadata.publisher` package. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test