Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r2106645938 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1282 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

chia7712 commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r2106243432 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1282 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna merged PR #18551: URL: https://github.com/apache/kafka/pull/18551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1940982151 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1284 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

lucasbru commented on PR #18551: URL: https://github.com/apache/kafka/pull/18551#issuecomment-2633423100 > Thanks a lot for this comment, @lucasbru ! I indeed found two fixes that I ported over to the streams membership manager. Do you want to re-review? I went through the latest comm

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

bbejeck commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1940245490 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1284 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on PR #18551: URL: https://github.com/apache/kafka/pull/18551#issuecomment-2632069474 > Thanks for the updates @cadonna. Just nits. Any fixes to port from the last changes to consumer/abstract membership manager? Thanks a lot for this comment, @lucasbru ! I indeed fo

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1939539568 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

lucasbru commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1939168555 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1246 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937616145 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937615571 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937614089 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937616145 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937615237 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937554379 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1937345936 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935891732 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935732824 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java: ## @@ -0,0 +1,1740 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935731250 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1249 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935170468 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935146957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935146957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935133047 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1243 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935129769 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1243 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1935116706 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

bbejeck commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1931048974 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on PR #18551: URL: https://github.com/apache/kafka/pull/18551#issuecomment-2622186185 @lucasbru I included your feedback. I added javadocs mainly on public methods. Please re-review. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933953860 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933941470 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933940323 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933938787 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933936528 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933929039 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933883214 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933839618 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933814926 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java: ## @@ -0,0 +1,1586 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933814519 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java: ## @@ -0,0 +1,1586 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933602594 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna commented on code in PR #18551: URL: https://github.com/apache/kafka/pull/18551#discussion_r1933568217 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java: ## @@ -0,0 +1,1586 @@ +/* + * Licensed to the Apache Software Fo

[PR] KAFKA-18538: Add Streams membership manager [kafka]

cadonna opened a new pull request, #18551: URL: https://github.com/apache/kafka/pull/18551 The Streams membership manager is used client-side in the background thread of the async consumer. For each member /consumer, it is responsible for: * keeping the member state, * keeping ass