dajac merged PR #18647:
URL: https://github.com/apache/kafka/pull/18647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #18647:
URL: https://github.com/apache/kafka/pull/18647#issuecomment-2603882097
Resolved the conflicts and removed `StopReplicaPartitionState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ijuma commented on PR #18647:
URL: https://github.com/apache/kafka/pull/18647#issuecomment-2603496337
Conflicts need to be resolved. Once those are done, you should be able to
delete the following class in `ReplicaManager`:
> case class StopReplicaPartitionState(leaderEpoch: Int, dele
dajac commented on code in PR #18647:
URL: https://github.com/apache/kafka/pull/18647#discussion_r1922706139
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2146,101 +2144,6 @@ class ReplicaManagerTest {
}
}
- @Test
Review Comment:
It is
dajac commented on code in PR #18647:
URL: https://github.com/apache/kafka/pull/18647#discussion_r1922706349
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2146,101 +2144,6 @@ class ReplicaManagerTest {
}
}
- @Test
- def testClearFetchPurga
ijuma commented on code in PR #18647:
URL: https://github.com/apache/kafka/pull/18647#discussion_r1922703177
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2146,101 +2144,6 @@ class ReplicaManagerTest {
}
}
- @Test
Review Comment:
Since
dajac opened a new pull request, #18647:
URL: https://github.com/apache/kafka/pull/18647
This patch removes `ReplicaManager#stopReplicas`. I have ensured that
removed unit tests are covered by other existing tests or updated to use kraft.
### Committer Checklist (excluded from commit
