ijuma merged PR #18468:
URL: https://github.com/apache/kafka/pull/18468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #18468:
URL: https://github.com/apache/kafka/pull/18468#issuecomment-2584989360
@junrao I have addressed your comments. Let me know if you have any other
comments or if this looks good. Thanks!
--
This is an automated message from the Apache Git Service.
To respond t
junrao commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911773904
##
clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java:
##
@@ -68,14 +68,12 @@ public static class Builder extends
AbstractRequest.Builder
junrao commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911773729
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(tru
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911740743
##
clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java:
##
@@ -68,14 +68,12 @@ public static class Builder extends
AbstractRequest.Builder
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911723432
##
clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java:
##
@@ -68,14 +68,12 @@ public static class Builder extends
AbstractRequest.Builder
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911713019
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911671034
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true
junrao commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911522823
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -150,14 +150,12 @@ class DefaultApiVersionManager(
}
val apiVersions = if (controllerApiVers
junrao commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911519969
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(tru
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911287231
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -150,14 +150,12 @@ class DefaultApiVersionManager(
}
val apiVersions = if (controllerApiVersi
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911246721
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911246721
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true
junrao commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910885482
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1112,21 +1109,13 @@ object GroupMetadataManager {
*
* @param groupMetadata curr
ijuma commented on PR #18468:
URL: https://github.com/apache/kafka/pull/18468#issuecomment-2583494897
The tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
ijuma commented on PR #18468:
URL: https://github.com/apache/kafka/pull/18468#issuecomment-2582928405
This is ready for review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910509751
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##
@@ -1551,40 +1514,14 @@ public void
testNonIncreasingOffsetRecordBatchHasMetric
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910505037
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910499333
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1640,15 +1639,6 @@ class KafkaConfigTest {
}
}
- @Test
- def testInvalidInterBrokerProt
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910498005
##
core/src/test/scala/unit/kafka/server/AlterPartitionManagerTest.scala:
##
@@ -486,74 +473,6 @@ class AlterPartitionManagerTest {
assertFutureThrows(future2, class
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910497443
##
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##
@@ -390,43 +390,6 @@ class AbstractFetcherThreadTest {
assertEquals(leaderState.highWate
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910495469
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -2593,45 +2574,12 @@ class GroupMetadataManagerTest {
time.milliseconds()
ijuma commented on PR #18468:
URL: https://github.com/apache/kafka/pull/18468#issuecomment-2582715360
There was a single failing test - pushed a simple fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910362866
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1112,21 +1108,13 @@ object GroupMetadataManager {
*
* @param groupMetadata curre
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910362543
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1085,17 +1084,14 @@ object GroupMetadataManager {
* Generates the payload for offset
dajac commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910349310
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1085,17 +1084,14 @@ object GroupMetadataManager {
* Generates the payload for offset
ijuma commented on PR #18468:
URL: https://github.com/apache/kafka/pull/18468#issuecomment-2582036357
I removed the relevant IBP constants too and fixed the known test failures.
I'll check the full test results tomorrow and will do a file by file pass then
too.
--
This is an automated me
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1909982724
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java:
##
@@ -238,7 +238,7 @@ public static CoordinatorRecord newGrou
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1909977316
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -731,7 +731,6 @@ private void cancelClassicGroupSizeCounter() {
ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1909975001
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequestTest.java:
##
@@ -40,20 +40,4 @@ public void testForConsumerRequiresVersion3() {
30 matches
Mail list logo
