Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-31 Thread via GitHub
Yunyung commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1937409376 ## core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala: ## @@ -59,63 +50,9 @@ class ZooKeeperClient(connectString: String, time: Time,

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-31 Thread via GitHub
chia7712 commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1937376383 ## core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala: ## @@ -59,63 +50,9 @@ class ZooKeeperClient(connectString: String, time: Time,

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
m1a2st commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1908103404 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -53,28 +37,9 @@ import scala.jdk.CollectionConverters._ * easier to migrate away from `ZkUtils` (since remov

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
chia7712 merged PR #18450: URL: https://github.com/apache/kafka/pull/18450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1908070818 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -53,28 +37,9 @@ import scala.jdk.CollectionConverters._ * easier to migrate away from `ZkUtils` (since rem

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
cmccabe commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1907916903 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1476,7 +1484,8 @@ class KRaftClusterTest { val parentDir = log.parentDir

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
cmccabe commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1907916903 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1476,7 +1484,8 @@ class KRaftClusterTest { val parentDir = log.parentDir

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
ijuma commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1907911940 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1476,7 +1484,8 @@ class KRaftClusterTest { val parentDir = log.parentDir

[PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
cmccabe opened a new pull request, #18450: URL: https://github.com/apache/kafka/pull/18450 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma