Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

ijuma commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1917650372 ## core/src/test/scala/unit/kafka/KafkaConfigTest.scala: ## @@ -41,6 +41,23 @@ class KafkaConfigTest { @AfterEach def tearDown(): Unit = Exit.resetExitProcedure()

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

ijuma commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1917532856 ## server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java: ## @@ -125,7 +124,7 @@ public class KRaftConfigs { public static final ConfigDef CONFIG_DEF

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

FrankYang0529 commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1917522755 ## server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java: ## @@ -125,7 +124,7 @@ public class KRaftConfigs { public static final ConfigDef CO

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

ijuma commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1913609725 ## server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java: ## @@ -125,7 +124,7 @@ public class KRaftConfigs { public static final ConfigDef CONFIG_DEF

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

ijuma commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1913609725 ## server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java: ## @@ -125,7 +124,7 @@ public class KRaftConfigs { public static final ConfigDef CONFIG_DEF

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

ijuma commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1913608955 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -635,21 +635,9 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (nodeId != br

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

FrankYang0529 commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1913389324 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -637,21 +637,12 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (nod

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

FrankYang0529 commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1913389324 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -637,21 +637,12 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (nod

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

FrankYang0529 commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1913389324 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -637,21 +637,12 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (nod

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

ijuma commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1912503825 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -637,21 +637,12 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (nodeId != b

Re: [PR] KAFKA-18331: Update process.roles to required configuration [kafka]

FrankYang0529 commented on code in PR #18414: URL: https://github.com/apache/kafka/pull/18414#discussion_r1910155126 ## server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java: ## @@ -125,7 +124,7 @@ public class KRaftConfigs { public static final ConfigDef CO