Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-21 Thread via GitHub
lucasbru merged PR #18442: URL: https://github.com/apache/kafka/pull/18442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
lucasbru commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922564511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -148,6 +148,19 @@ private static Map decideParti

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
cadonna commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922207534 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -148,6 +148,19 @@ private static Map decidePartit

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
cadonna commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922205600 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Soft

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
cadonna commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922205600 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Soft

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
cadonna commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922205600 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Soft

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
lucasbru commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922100063 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/TopicMetadataTest.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-13 Thread via GitHub
cadonna commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1912862606 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TopicMetadata.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-10 Thread via GitHub
lucasbru commented on PR #18442: URL: https://github.com/apache/kafka/pull/18442#issuecomment-2582922664 @cadonna I moved the source topic check as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-08 Thread via GitHub
lucasbru commented on PR #18442: URL: https://github.com/apache/kafka/pull/18442#issuecomment-2577589618 PTAL @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.