Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-10 Thread via GitHub
lucasbru merged PR #18397: URL: https://github.com/apache/kafka/pull/18397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-10 Thread via GitHub
lucasbru commented on PR #18397: URL: https://github.com/apache/kafka/pull/18397#issuecomment-2582449912 @cadonna As discussed offline, I can add a third validation for source topics in a different place and throw IllegalStateException here. I will do these changes as I rebase `InternalTopi

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-09 Thread via GitHub
lucasbru commented on PR #18397: URL: https://github.com/apache/kafka/pull/18397#issuecomment-2580094197 Ready for re-review @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-09 Thread via GitHub
lucasbru commented on code in PR #18397: URL: https://github.com/apache/kafka/pull/18397#discussion_r1908739762 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/CopartitionedTopicsEnforcerTest.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-09 Thread via GitHub
lucasbru commented on code in PR #18397: URL: https://github.com/apache/kafka/pull/18397#discussion_r1908706477 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/CopartitionedTopicsEnforcer.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apa

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-09 Thread via GitHub
cadonna commented on code in PR #18397: URL: https://github.com/apache/kafka/pull/18397#discussion_r1908525485 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/CopartitionedTopicsEnforcer.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apac

Re: [PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-06 Thread via GitHub
lucasbru commented on PR #18397: URL: https://github.com/apache/kafka/pull/18397#issuecomment-2573116259 PTAL @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] KAFKA-18311: Enforcing copartitioned topics (4/N) [kafka]

2025-01-06 Thread via GitHub
lucasbru opened a new pull request, #18397: URL: https://github.com/apache/kafka/pull/18397 A simplified port of "CopartitionedTopicsEnforcer" from the client-side to the group coordinator. This class is responsible for enforcing the number of partitions in copartitioned topics. For