Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-10 Thread via GitHub
dajac merged PR #18455: URL: https://github.com/apache/kafka/pull/18455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18455: URL: https://github.com/apache/kafka/pull/18455#discussion_r1909976659 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java: ## @@ -43,7 +43,7 @@ public abstract class Coordin

Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-09 Thread via GitHub
dajac commented on code in PR #18455: URL: https://github.com/apache/kafka/pull/18455#discussion_r1909928135 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordSerde.java: ## @@ -16,138 +16,31 @@ */ package org.apache.kafka.coordinator

Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-09 Thread via GitHub
dajac commented on code in PR #18455: URL: https://github.com/apache/kafka/pull/18455#discussion_r1909927366 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java: ## @@ -43,7 +43,7 @@ public abstract class CoordinatorRecordS

Re: [PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-09 Thread via GitHub
AndrewJSchofield commented on code in PR #18455: URL: https://github.com/apache/kafka/pull/18455#discussion_r1909115021 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordSerde.java: ## @@ -16,138 +16,31 @@ */ package org.apache.kafka.

[PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-08 Thread via GitHub
dajac opened a new pull request, #18455: URL: https://github.com/apache/kafka/pull/18455 This patch updates the GroupCoordinatorSerde and the ShareGroupCoordinatorSerde to leverage the CoordinatorRecordType to deserialize records. With this, newly added record are automatically picked up. I