Re: [PR] KAFKA-18295: Remove deprecated function Partitioner#onNewBatch [kafka]

2024-12-27 Thread via GitHub
chia7712 merged PR #18282: URL: https://github.com/apache/kafka/pull/18282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18295: Remove deprecated function Partitioner#onNewBatch [kafka]

2024-12-26 Thread via GitHub
chia7712 commented on PR #18282: URL: https://github.com/apache/kafka/pull/18282#issuecomment-2563310552 @FrankYang0529 could you please remove `RecordAppendResult#abortForNewBatch`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-18295: Remove deprecated function Partitioner#onNewBatch [kafka]

2024-12-25 Thread via GitHub
FrankYang0529 commented on code in PR #18282: URL: https://github.com/apache/kafka/pull/18282#discussion_r1897338025 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1020,9 +1011,6 @@ private Future doSend(ProducerRecord record, Callback call

Re: [PR] KAFKA-18295: Remove deprecated function Partitioner#onNewBatch [kafka]

2024-12-24 Thread via GitHub
chia7712 commented on code in PR #18282: URL: https://github.com/apache/kafka/pull/18282#discussion_r1897164693 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1020,9 +1011,6 @@ private Future doSend(ProducerRecord record, Callback call

[PR] KAFKA-18295: Remove deprecated function Partitioner#onNewBatch [kafka]

2024-12-20 Thread via GitHub
FrankYang0529 opened a new pull request, #18282: URL: https://github.com/apache/kafka/pull/18282 The `Partitioner#onNewBatch` has been deprecated by KAFKA-10888 since 2022. It can be removed from version 4.0. ### Committer Checklist (excluded from commit message) - [ ] Verify desig