TaiJuWu commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2505078614
Back port to 3.9 branch https://github.com/apache/kafka/pull/17970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 merged PR #17954:
URL: https://github.com/apache/kafka/pull/17954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
TaiJuWu commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503855443
> @TaiJuWu Could you please fix
>
>
https://github.com/apache/kafka/blob/434fe7c26e31a6cfeb5e17e83fb52a260eac398e/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegration
chia7712 commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503840843
@TaiJuWu Could you please fix
https://github.com/apache/kafka/blob/434fe7c26e31a6cfeb5e17e83fb52a260eac398e/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala#L
TaiJuWu commented on code in PR #17954:
URL: https://github.com/apache/kafka/pull/17954#discussion_r1860502292
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala:
##
@@ -312,7 +312,8 @@ class CoordinatorLoaderImplTest {
.thenThrow(new Ru
chia7712 commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503562037
@TaiJuWu Could you please use `Using.resource` to minimize the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
TaiJuWu commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503550104
> RaftManagerTest
> RaftManagerTest
Both of them use `Using.resource` and the method can throw Exception so
there is no issue.
--
This is an automated message from
chia7712 commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503541384
@TaiJuWu `RaftManagerTest` and `KafkaServerTestHarness` are using `Using`.
Could you please fix them as well?
--
This is an automated message from the Apache Git Service.
To respond to
TaiJuWu commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503268396
fail test:
```
FAILED ❌ CoordinatorLoaderImplTest >
testDeserializationErrorFailsTheLoading()
FAILED ❌ SaslClientsWithInvalidCredentialsTest >
testTransactionalProducerWithAuthen
frankvicky commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2503114950
Hi @chia7712
I have file a PR for it #17954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2502771967
@frankvicky Could you please a PR to fix the ``CoordinatorLoaderImplTest` `
first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #17954:
URL: https://github.com/apache/kafka/pull/17954#issuecomment-2502763639
@TaiJuWu Could you replace all `Using` by "try-release" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
12 matches
Mail list logo
