github-actions[bot] closed pull request #17908: KAFKA-18068: Fixing typo in
ProducerConfig
URL: https://github.com/apache/kafka/pull/17908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
github-actions[bot] commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2760101395
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2683813615
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
chia7712 commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2504785460
> I meant that we could temporarily have both spellings starting in AK 4.0.
Something like:
sorry that I didn't get your point :(
> That wouldn't break the user's code at al
AndrewJSchofield commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2504764436
@chia7712 I meant that we could temporarily have both spellings starting in
AK 4.0. Something like:
```
public static final String PARTITIONER_ADAPTIVE_PARTITIONING_ENAB
robvadai commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2503765564
@chia7712 will do eventually, just need to get familiar with the process,
I'll use this guide:
https://cwiki.apache.org/confluence/display/kafka/kafka+improvement+proposals
--
This is
chia7712 commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2503732512
> This means this PR can define the correct spelling without a new KIP. A
KIP will be needed to deprecate and then remove the erroneous constant but we
can do that afterwards.
The
AndrewJSchofield commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2503121184
Actually, thinking more about this, KIP-794
https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=191336857#content/view/191336857
defines the config without the s
AndrewJSchofield commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2501575544
@chia7712 is correct. It would need a KIP too, which would be a trivial KIP
so not much effort.
--
This is an automated message from the Apache Git Service.
To respond to the m
AndrewJSchofield commented on code in PR #17908:
URL: https://github.com/apache/kafka/pull/17908#discussion_r1858989261
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -97,17 +97,17 @@ public class ProducerConfig extends AbstractConfig {
chia7712 commented on PR #17908:
URL: https://github.com/apache/kafka/pull/17908#issuecomment-2493434943
@robvadai thanks for this patch. those configs are public so we need KIP
before fixing them
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
robvadai opened a new pull request, #17908:
URL: https://github.com/apache/kafka/pull/17908
Fixed typo in ProducerConfig.
The variables and descriptions were not tested so the fact it can be
compiled tests integrity.
### Committer Checklist (excluded from commit message)
- [
12 matches
Mail list logo
