Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2025-03-03 Thread via GitHub
mjsax commented on PR #17931: URL: https://github.com/apache/kafka/pull/17931#issuecomment-2694932880 This PR introduced a regression for EOS, and was reverted for `4.0.0` release. https://github.com/apache/kafka/pull/19078 -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2024-12-09 Thread via GitHub
ableegoldman commented on PR #17931: URL: https://github.com/apache/kafka/pull/17931#issuecomment-2529891486 Merged to trunk. Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2024-12-09 Thread via GitHub
ableegoldman merged PR #17931: URL: https://github.com/apache/kafka/pull/17931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2024-12-05 Thread via GitHub
frankvicky commented on PR #17931: URL: https://github.com/apache/kafka/pull/17931#issuecomment-2522265195 Hi @guozhangwang @ableegoldman Thanks for review. I have add a unit test for this case, PTAL 🐧 -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2024-12-05 Thread via GitHub
guozhangwang commented on PR #17931: URL: https://github.com/apache/kafka/pull/17931#issuecomment-2521705409 LGTM overall, but I'm wondering if some more unit test cases would better add to reflect the original bug? Up to @frankvicky and @ableegoldman -- This is an automated message from

[PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

2024-11-23 Thread via GitHub
frankvicky opened a new pull request, #17931: URL: https://github.com/apache/kafka/pull/17931 JIRA: KAFKA-18067 To avoid leaking producers, we should add a 'closed` flag to `StreamProducer` indicating whether we should reset prouder. ### Committer Checklist (excluded from commi