Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-22 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2493929966 Remove some ZK tests here https://github.com/apache/kafka/pull/17913/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-21 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2492643661 For fixing `DynamicBrokerReconfigurationTest` : https://github.com/apache/kafka/pull/17905 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-21 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2492396432 remove `SaslPlainPlaintextConsumerTest.testZkAclsDisabled`: https://github.com/apache/kafka/pull/17902 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-13 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2474335828 Convert SaslClientsWithInvalidCredentialsTest.scala to KRaft https://github.com/apache/kafka/pull/17803 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2471996386 Convert `GssapiAuthenticationTest` : https://github.com/apache/kafka/pull/17786/files -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-12 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2471500349 https://github.com/apache/kafka/pull/17780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-11 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2469391903 Convert `RackAwareAutoTopicCreationTest` to KRaft: https://github.com/apache/kafka/pull/17766 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-11 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2469331943 Created https://github.com/apache/kafka/pull/17765 for fixing the tests inheriting from `RebootstrapTest` -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-11 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2469023044 Convert `AddPartitionsToTxnRequestServerTest` https://github.com/apache/kafka/pull/17762 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-11 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2468967383 Convert `ConsumerTopicCreationTest` : https://github.com/apache/kafka/pull/17760/files -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-11 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2468929018 Fixing `FetchRequestDownConversionConfigTest` here : https://github.com/apache/kafka/pull/17759 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-11 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2468787608 another fix here https://github.com/apache/kafka/pull/17757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-10 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2466988614 #17746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-10 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2466980219 Remove `MetadataRequestBetweenDifferentIbpTest.scala` in #17745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-10 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2466978289 I split the fix of MetricsTest out to #17744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-08 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2465956095 > Out of curiosity, what is the next if we have a zk-only list? There are some things that don't need to be tested any more, because they're gone. For example, there are a bunch of

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-08 Thread via GitHub
chia7712 commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2465953791 Out of curiosity, what is the next if we have a zk-only list? 1. migrate the tests to Kraft if the tests are required by Kraft too 2. Remove the tests if the bugs happen in Kraft

[PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-08 Thread via GitHub
cmccabe opened a new pull request, #17727: URL: https://github.com/apache/kafka/pull/17727 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma