chia7712 closed pull request #17998: KAFKA-17836: Move RackAwareTest to server
module
URL: https://github.com/apache/kafka/pull/17998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
github-actions[bot] commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2716336355
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
chia7712 merged PR #19021:
URL: https://github.com/apache/kafka/pull/19021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
xijiu commented on PR #19021:
URL: https://github.com/apache/kafka/pull/19021#issuecomment-2680799064
@chia7712 Thanks for code review and I have fixed them, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
chia7712 commented on code in PR #19021:
URL: https://github.com/apache/kafka/pull/19021#discussion_r1969002300
##
core/src/test/java/kafka/admin/RackAwareAutoTopicCreationTest.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
xijiu opened a new pull request, #19021:
URL: https://github.com/apache/kafka/pull/19021
As title.
see discussion:
https://github.com/apache/kafka/pull/17998#issuecomment-2535339509
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
chia7712 commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2535339509
> Are RackAwareTest and AdminRackAwareTest testing any logic used when not
running with ZooKeeper? It seems all the callers of the methods they check are
from ZooKeeper logic.
yes
chiacyu commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2532075892
Hi, @mimaison
I've check the logic and if I'm not missing anything, these methods are used
by the service related Zookeeper.
Should we just remove all since we're removing Zookeeper
mimaison commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2532104441
Yes we should not spend time rewritting them as we will be deleting them
soon.
However I don't think we're ready to delete them yet, see
https://issues.apache.org/jira/browse/KAFKA-17
mimaison commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2531311818
Are `RackAwareTest` and `AdminRackAwareTest` testing any logic used when not
running with ZooKeeper? It seems all the callers of the methods they check are
from ZooKeeper logic.
--
Th
chiacyu commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2514613473
Hi, @chia7712
Please take a look while you're available, thanks!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
TaiJuWu commented on code in PR #17998:
URL: https://github.com/apache/kafka/pull/17998#discussion_r1864732418
##
server-common/src/main/java/org/apache/kafka/admin/ReplicaDistributions.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
chiacyu commented on PR #17998:
URL: https://github.com/apache/kafka/pull/17998#issuecomment-2509514283
The original discussion is https://github.com/apache/kafka/pull/17646, this
new one is to solve the merge conflicts. @frankvicky , please take a look while
you're available.
--
This is
chiacyu opened a new pull request, #17998:
URL: https://github.com/apache/kafka/pull/17998
`RackAwareTest` and `AdminRackAwareTest` should be moved to server's
org.apache.kafka.admin package. Also, `RackAwareAutoTopicCreationTest` can be
removed as it is for zk only.
### Committer Ch
chiacyu commented on PR #17646:
URL: https://github.com/apache/kafka/pull/17646#issuecomment-2508983319
Close the PR to solved conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
chiacyu closed pull request #17646: KAFKA-17836: Move RackAwareTest to server
module
URL: https://github.com/apache/kafka/pull/17646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
frankvicky commented on code in PR #17646:
URL: https://github.com/apache/kafka/pull/17646#discussion_r1824298235
##
server-common/src/test/java/org/apache/kafka/admin/AdminRackAwareTest.java:
##
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
chiacyu opened a new pull request, #17646:
URL: https://github.com/apache/kafka/pull/17646
As titled, this pr move the `RackAwareTest`, `AdminRackAwareTest` to
`server-common`, please check
[KAFKA-17836](https://issues.apache.org/jira/browse/KAFKA-17836) for more
details. thanks!
##
18 matches
Mail list logo
