DL1231 commented on PR #19430:
URL: https://github.com/apache/kafka/pull/19430#issuecomment-2853819965
@apoorvmittal10 @AndrewJSchofield `group.share.delivery.count.limit` is
limited to 2~10 and cannot be set to 1, do we need to modify this definition or
modify this IT?
--
This is an aut
apoorvmittal10 commented on PR #19430:
URL: https://github.com/apache/kafka/pull/19430#issuecomment-2853825000
> @apoorvmittal10 @AndrewJSchofield `group.share.delivery.count.limit` is
limited to 2~10 and cannot be set to 1, do we need to modify this definition or
modify this IT?
Yea
DL1231 commented on PR #19430:
URL: https://github.com/apache/kafka/pull/19430#issuecomment-2845094174
@AndrewJSchofield @apoorvmittal10 Thanks for your suggestion. I’ll finish it
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AndrewJSchofield merged PR #19430:
URL: https://github.com/apache/kafka/pull/19430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
AndrewJSchofield commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2066391545
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2000,6 +1998,29 @@ public void testShareCon
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2063589486
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2999,23 +3010,32 @@ private boolean hasOngoingStateTransition() {
/**
*
DL1231 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2059445472
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -4887,14 +4889,50 @@ public void
testReleaseAcquiredRecordsBatchesPostStartOffsetMovementToMiddl
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2055767896
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -3003,24 +3014,32 @@ private boolean hasOngoingStateTransition() {
* if the state u
DL1231 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2055365066
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -3003,24 +3014,32 @@ private boolean hasOngoingStateTransition() {
* if the state update is
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2052861184
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -197,6 +197,16 @@ public byte id() {
}
}
+/**
+ * The DeliveryCountOp
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2048869119
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1011,6 +1011,8 @@ private Optional
releaseAcquiredRecordsForPerOffsetBatch(String membe
DL1231 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2043802656
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1011,6 +1011,8 @@ private Optional
releaseAcquiredRecordsForPerOffsetBatch(String membe
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2039566989
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1011,6 +1011,8 @@ private Optional
releaseAcquiredRecordsForPerOffsetBatch(String membe
AndrewJSchofield commented on PR #19430:
URL: https://github.com/apache/kafka/pull/19430#issuecomment-2794085366
@DL1231 Looks like a compile failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
DL1231 opened a new pull request, #19430:
URL: https://github.com/apache/kafka/pull/19430
For records which are automatically released as a result of closing a share
session normally, the delivery count should not be incremented. These records
were fetched but they were not actually deliver
15 matches
Mail list logo
