Re: [PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-15 Thread via GitHub
omkreddy merged PR #16335: URL: https://github.com/apache/kafka/pull/16335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-14 Thread via GitHub
AndrewJSchofield commented on PR #16335: URL: https://github.com/apache/kafka/pull/16335#issuecomment-2168022748 @apoorvmittal10 Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-14 Thread via GitHub
AndrewJSchofield commented on code in PR #16335: URL: https://github.com/apache/kafka/pull/16335#discussion_r1639801028 ## server-common/src/main/java/org/apache/kafka/server/group/share/Persister.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-14 Thread via GitHub
AndrewJSchofield commented on code in PR #16335: URL: https://github.com/apache/kafka/pull/16335#discussion_r1639797544 ## server-common/src/main/java/org/apache/kafka/server/group/share/ReadShareGroupStateParameters.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Softw

Re: [PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-14 Thread via GitHub
AndrewJSchofield commented on code in PR #16335: URL: https://github.com/apache/kafka/pull/16335#discussion_r1639795031 ## server-common/src/main/java/org/apache/kafka/server/group/share/PartitionAllData.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-14 Thread via GitHub
apoorvmittal10 commented on code in PR #16335: URL: https://github.com/apache/kafka/pull/16335#discussion_r1639739009 ## server-common/src/main/java/org/apache/kafka/server/group/share/GroupTopicPartitionData.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foun

[PR] KAFKA-16950: Define Persister interfaces and RPCs [kafka]

2024-06-13 Thread via GitHub
AndrewJSchofield opened a new pull request, #16335: URL: https://github.com/apache/kafka/pull/16335 Define the interfaces and RPCs for share-group persistence. This PR is just RPCs and interfaces to allow building of the broker components which depend upon them. The implementation will foll