Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-06-03 Thread via GitHub
omkreddy merged PR #16134: URL: https://github.com/apache/kafka/pull/16134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-06-03 Thread via GitHub
AndrewJSchofield commented on code in PR #16134: URL: https://github.com/apache/kafka/pull/16134#discussion_r1624638311 ## clients/src/main/java/org/apache/kafka/clients/consumer/MockShareConsumer.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-06-03 Thread via GitHub
omkreddy commented on code in PR #16134: URL: https://github.com/apache/kafka/pull/16134#discussion_r1624558823 ## clients/src/main/java/org/apache/kafka/clients/consumer/MockShareConsumer.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-06-03 Thread via GitHub
omkreddy commented on PR #16134: URL: https://github.com/apache/kafka/pull/16134#issuecomment-2145321139 there are checkstyle errors: ``` [2024-06-03T13:13:54.181Z] * What went wrong: [2024-06-03T13:13:54.181Z] Execution failed for task ':clients:checkstyleMain'. [202

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-06-03 Thread via GitHub
AndrewJSchofield commented on PR #16134: URL: https://github.com/apache/kafka/pull/16134#issuecomment-2144903896 Closing and re-opening PR to force rebuild. This should fix the build failures because of a recent merge. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-06-03 Thread via GitHub
AndrewJSchofield closed pull request #16134: KAFKA-16715: Create KafkaShareConsumer interfaces URL: https://github.com/apache/kafka/pull/16134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-05-30 Thread via GitHub
AndrewJSchofield commented on PR #16134: URL: https://github.com/apache/kafka/pull/16134#issuecomment-2139446089 The build will not succeed until https://github.com/apache/kafka/pull/16022 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-05-30 Thread via GitHub
AndrewJSchofield opened a new pull request, #16134: URL: https://github.com/apache/kafka/pull/16134 This PR introduces ShareConsumer and KafkaShareConsumer. It is focused entirely on the minimal additions required to introduce the external programming interfaces. ### Committer Checkl