chia7712 commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2503565352
#17954 will correct the usage of `Using`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2502688514
Sorry for the trouble. I’ll take over the Jira. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
frankvicky commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2502685865
Oops, I will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
ijuma commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2502412144
> It looks like this change is silently suppressing all errors in tests that
were updated, since we don't check the resulting Try for failures.
Ouch! A bunch of tests were broken as a
jolshan commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2502363433
https://issues.apache.org/jira/browse/KAFKA-18100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jolshan commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2502357138
@chia7712 I will file a ticket for this. I just tested by including a
assertEquals(1, 2) in a `Using` block and the test still passed.
--
This is an automated message from the Apache Gi
xvrl commented on PR #15881:
URL: https://github.com/apache/kafka/pull/15881#issuecomment-2501874334
it looks like this change is silently suppressing all errors in tests that
were updated, since we don't check the resulting Try for failures.
--
This is an automated message from the Apach
chia7712 merged PR #15881:
URL: https://github.com/apache/kafka/pull/15881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky opened a new pull request, #15881:
URL: https://github.com/apache/kafka/pull/15881
Check all uses of `TestUtils#resource` and replace with `scala.util.Using`
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentati
