Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante merged PR #6934: URL: https://github.com/apache/kafka/pull/6934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on PR #6934: URL: https://github.com/apache/kafka/pull/6934#issuecomment-2102553283 Thank you @C0urante. I updated the description (please tell me if I need to add more) there. Do you want to me squash the fixups or you squash when merge? -- This is an automated messag

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1595365475 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void testDeleteConnectorCreatedWit

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1595357027 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java: ## @@ -242,6 +242,19 @@ public Response putConnectorConfig(final

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void testDeleteConnectorCreatedW

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on PR #6934: URL: https://github.com/apache/kafka/pull/6934#issuecomment-2098991457 Thanks @ivanyu, this is really close. One other thing--can you update the description with a brief overview of the PR (probably enough to just mention the new endpoint and its behavior), a

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void testDeleteConnectorCreatedW

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void testDeleteConnectorCreatedW

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592847527 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java: ## @@ -242,6 +242,19 @@ public Response putConnectorConfig(fina

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592838802 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1144,6 +1144,21 @@ public void putConnectorConfig(final Stri

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on PR #6934: URL: https://github.com/apache/kafka/pull/6934#issuecomment-2092245514 I also added the integration test as you proposed @C0urante -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1588022076 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1144,6 +1144,21 @@ public void putConnectorConfig(final String

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587989524 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1144,6 +1144,21 @@ public void putConnectorConfig(final String

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587970461 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -751,6 +754,74 @@ public void testPutConnectorConfig() throws

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587966298 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -751,6 +754,74 @@ public void testPutConnectorConfig() throws

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587963241 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -751,6 +754,74 @@ public void testPutConnectorConfig() throws

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587958141 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -2336,6 +2336,95 @@ public void testPutConnectorConfig() th

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587955412 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -2336,6 +2336,95 @@ public void testPutConnectorConfig() th

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587938094 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -2336,6 +2336,95 @@ public void testPutConnectorConfig() th

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587929296 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -246,6 +246,31 @@ private synchronized void putConnectorConfig(St

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587926661 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -246,6 +246,31 @@ private synchronized void putConnectorConfig(St

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587918212 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java: ## @@ -242,6 +242,19 @@ public Response putConnectorConfig(final

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587904583 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java: ## @@ -242,6 +242,19 @@ public Response putConnectorConfig(final

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

ivanyu commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1587717243 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -992,4 +992,15 @@ public List setWorkerLoggerLevel(String namespace, String d

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1568959278 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java: ## @@ -242,6 +242,19 @@ public Response putConnectorConfig(fina