Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2622947501 Thanks for supporting 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2622612299 Thanks for this PR. Really cool to have this migration guide! Merged to `trunk` and cherry-picked to `4.0` branch. Feel free to do a "MINOR" follow-up PR for the Javadocs issue

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax merged PR #18314: URL: https://github.com/apache/kafka/pull/18314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933744549 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933254272 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key - -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933254272 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key - -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2620494379 @mjsax, I have pushed some updates. All that's missing are the descriptions for ContextualProcessors. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933125039 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933125223 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933125039 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933121266 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933121266 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933119733 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933073009 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933066974 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933065386 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933065851 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933062713 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1933062865 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3098,994 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2614460950 @mjsax, I should not have expressed myself very well, sorry. By Friday, I mean I had resolved most of the conversations you pointed out, with the exception of the _update migrating/apply

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2614033630 I did not see any push into the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1928018597 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3097,615 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1928019115 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3097,615 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1928018450 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3097,615 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1928003404 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3097,152 +3097,615 @@ KTable-KTable Foreign-Key -

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2608700567 @mjsax, I forgot to mention that I am updating the Markdown. So you could, for example, check the addition of the old process example. I'll try to send new patches for the slang example

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2605940755 Hi, @mjsax! I have updated (instead of removing) the migration/applying section and added the example for old process. Now, I am reviewing the Slang example and analyzing the use of Cont

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2605263355 @fonsdant -- How are things. Any progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2591103697 No worries. Let's just try to finish asap, and if need be, we update the docs after the release. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2591093065 @mjsax, I suppose we won't be able to finish before the freeze 😔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1913737465 ## docs/streams/developer-guide/dsl-api.html: ## @@ -64,7 +64,7 @@ -Applying pro

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2585901473 @mjsax, how about using the `PopularPageEmailAlert` of the _Applying processors and transformers (Processor API integration)_ section? ```java package org.apache.kafka.streams.k

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2585000776 @mjsax, I removed the "migration process" section to simplify the guide, unified the method reference, added the remaining `to`, fixed the `flatTransformValues`-`processValues` behavior,

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2581326906 Sorry, @mjsax. I've been a little busy these days. I fully agree with finishing it before the code freeze. I should be able to send an update by tomorrow. -- This is an automated mess

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2580965258 @fonsdant -- Any updates on this PR. Would be great to finish this before code freeze (Jan/15). -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2568465445 Did not look into HTML yet... ``` The migration process consists of: Replace Transformer with Processor or ValueTransformer with FixedKeyProcessor; Replace record key and val

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1896961093 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3243,6 +3244,177 @@ KTable-KTable Foreign-Key // `Processor` interface, see further down below.

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2566716097 I have wrote a "draft" into Markdown, before to write it into HTML. I hope this helps the review. Now, I will translate it to HTML. *** # Migrating from transform to process

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2565928361 > may I format the code? Some blocks are not indented properly. I understand it might pollute the diff in code changes, so if I may, I would do it as a final commit. Let's do this in

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2564397291 @mjsax, can I format the code? Some blocks are not indented correctly. I understand it might pollute the diff in code changes, so if I may, I would do it as a final commit. -- This is

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

mjsax commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1896960916 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3243,6 +3244,177 @@ KTable-KTable Foreign-Key // `Processor` interface, see further down below.