Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-15 Thread via GitHub
dongnuo123 closed pull request #15442: KAFKA-16313: offline group protocol migration URL: https://github.com/apache/kafka/pull/15442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-08 Thread via GitHub
dajac commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1517690579 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void testOnConsumerGroupStateTrans

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516858539 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void testOnConsumerGroupState

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516784744 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void testOnConsumerGroupState

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516784744 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void testOnConsumerGroupState

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dajac commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516473475 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void testOnConsumerGroupStateTrans

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516453885 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void testOnConsumerGroupState

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dajac commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1515850376 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3500,6 +3503,56 @@ public void maybeDeleteGroup(String groupId, L