Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-08 Thread via GitHub
divijvaidya commented on PR #15132: URL: https://github.com/apache/kafka/pull/15132#issuecomment-1880673686 backported to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-06 Thread via GitHub
divijvaidya merged PR #15132: URL: https://github.com/apache/kafka/pull/15132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-06 Thread via GitHub
divijvaidya commented on PR #15132: URL: https://github.com/apache/kafka/pull/15132#issuecomment-1879695777 KafkaAPIs test is successful - https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15132/2/testReport/kafka.server/KafkaApisTest/ -- This is an automated message from the

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-05 Thread via GitHub
jolshan commented on PR #15132: URL: https://github.com/apache/kafka/pull/15132#issuecomment-1879484649 > but there are more... 😱 In all seriousness, thanks for taking care of this. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-05 Thread via GitHub
showuon commented on code in PR #15132: URL: https://github.com/apache/kafka/pull/15132#discussion_r1442645316 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -4075,6 +4122,7 @@ class KafkaApisTest extends Logging { assertEquals(authorizedTopic, meta

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-05 Thread via GitHub
divijvaidya commented on code in PR #15132: URL: https://github.com/apache/kafka/pull/15132#discussion_r1442639976 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -4075,6 +4122,7 @@ class KafkaApisTest extends Logging { assertEquals(authorizedTopic,

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-04 Thread via GitHub
showuon commented on PR #15132: URL: https://github.com/apache/kafka/pull/15132#issuecomment-1878091765 @divijvaidya , this should be the last fix for kafkaApisTest. (Hope so!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-04 Thread via GitHub
showuon commented on code in PR #15132: URL: https://github.com/apache/kafka/pull/15132#discussion_r1442473158 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2061,20 +2071,24 @@ class KafkaApisTest extends Logging { responseCallback.capture(),

Re: [PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-04 Thread via GitHub
showuon commented on code in PR #15132: URL: https://github.com/apache/kafka/pull/15132#discussion_r1442472935 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -1669,12 +1671,16 @@ class KafkaApisTest extends Logging { val request = buildRequest(offsetC

[PR] KAFKA-16059: close more kafkaApis instances [kafka]

2024-01-04 Thread via GitHub
showuon opened a new pull request, #15132: URL: https://github.com/apache/kafka/pull/15132 I thought we've closed all kafkaApis instances in KafkaApisTest, but there are more... ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]