jeqo commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1988994745
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -238,35 +207,137 @@ private Iterable
iterable(Supplier allocate)
ijuma commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1985844349
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -238,35 +207,137 @@ private Iterable
iterable(Supplier allocate)
junrao commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1985806237
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -238,35 +207,137 @@ private Iterable
iterable(Supplier allocate)
ijuma commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1985206261
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -238,35 +207,137 @@ private Iterable
iterable(Supplier allocate)
jeqo commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2706210945
@showuon thanks! build looks good after rebase 👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
showuon merged PR #15241:
URL: https://github.com/apache/kafka/pull/15241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2705463895
@jeqo , could you try to rebase to the latest trunk? I'd like to verify the
change doesn't break the build. Thanks.
--
This is an automated message from the Apache Git Service.
To respo
github-actions[bot] commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2646846194
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2466582626
The patch LGTM. It needs second set of eyes as we are re-opening a closed
index. cc @showuon @satishd PTAL.
--
This is an automated message from the Apache Git Service.
To respond to
kamalcph commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1835574783
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -238,35 +207,137 @@ private Iterable
iterable(Supplier allocate)
mjd95 commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2376460752
We were the ones discussing with @jeqo - the "caching closed channels" issue
was happening regularly for us on 3.8 in production, the thread doing a remote
read was interrupted while iterat
jeqo commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2376067147
We have received feedback of this issue persisting on 3.8, so I guess we
could have another look at this PR.
@showuon I have made the TransactionIndexFile channel access methods
synch
jeqo commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1650469442
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java:
##
@@ -190,75 +175,145 @@ public void sanityCheck() {
AbortedTxn aborte
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2146529487
@jeqo
Any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kamalcph commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1617724047
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -633,6 +657,10 @@ public String toString() {
", txnIn
jeqo commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2134015516
@kamalcph good catch! You're right. I have refactored the code a bit further
to reopen the txn index properly. PTAL
--
This is an automated message from the Apache Git Service.
To respond
showuon commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2126963749
@jeqo , could you address @kamalcph 's comment above? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2074186450
Thanks for the patch @jeqo!
I was able to reproduce the exception mentioned in the ticket by calling
close in-middle of collecting the aborted transactions. The fix doesn't resolv
nikramakrishnan commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2072530250
Bump! @satishd @kamalcph can we get this review going? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nikramakrishnan commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1509082067
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -522,6 +522,18 @@ public TimeIndex timeIndex() {
// Visi
nikramakrishnan commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1509082067
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -522,6 +522,18 @@ public TimeIndex timeIndex() {
// Visi
jeqo opened a new pull request, #15241:
URL: https://github.com/apache/kafka/pull/15241
Cached TransactionIndex may get closed if interrupted, causing following
calls to always fail with ClosedChannelException, and forcing process to be
restarted. In order to avoid this issue, a new method
22 matches
Mail list logo
