Re: [PR] KAFKA-15853: Refactor some of KafkaConfig properties [kafka]

2024-04-27 Thread via GitHub
chia7712 commented on code in PR #15822: URL: https://github.com/apache/kafka/pull/15822#discussion_r1581994613 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -77,7 +78,7 @@ public class CommonClientConfigs { public static final String C

Re: [PR] KAFKA-15853: Refactor some of KafkaConfig properties [kafka]

2024-04-27 Thread via GitHub
OmniaGM commented on code in PR #15822: URL: https://github.com/apache/kafka/pull/15822#discussion_r1581891739 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -77,7 +78,7 @@ public class CommonClientConfigs { public static final String CL

Re: [PR] KAFKA-15853: Refactor some of KafkaConfig properties [kafka]

2024-04-27 Thread via GitHub
OmniaGM commented on code in PR #15822: URL: https://github.com/apache/kafka/pull/15822#discussion_r1581885612 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -77,7 +78,7 @@ public class CommonClientConfigs { public static final String CL

Re: [PR] KAFKA-15853: Refactor some of KafkaConfig properties [kafka]

2024-04-27 Thread via GitHub
chia7712 commented on code in PR #15822: URL: https://github.com/apache/kafka/pull/15822#discussion_r1581875016 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -77,7 +78,7 @@ public class CommonClientConfigs { public static final String C

[PR] KAFKA-15853: Refactor some of KafkaConfig properties [kafka]

2024-04-27 Thread via GitHub
OmniaGM opened a new pull request, #15822: URL: https://github.com/apache/kafka/pull/15822 - Use CommonClientConfigs and QuroumConfig configs, defaults and docs directly instead of creating reference variables. - The pr also renamed default values for QuorumConfig and CommonClientConfigs