Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-23 Thread via GitHub
chia7712 merged PR #19440: URL: https://github.com/apache/kafka/pull/19440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-23 Thread via GitHub
chia7712 commented on PR #19440: URL: https://github.com/apache/kafka/pull/19440#issuecomment-2824873703 the timeout is fixed by #19526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-22 Thread via GitHub
kirktrue commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2054567227 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3799,10 +3799,11 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES, n

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-20 Thread via GitHub
chia7712 commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2051733277 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3799,10 +3799,11 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES, n

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-18 Thread via GitHub
kirktrue commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2051356316 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -171,7 +171,25 @@ public class TransactionManager { * *

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-18 Thread via GitHub
kirktrue commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2051047881 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -171,7 +171,25 @@ public class TransactionManager { * *

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-18 Thread via GitHub
kirktrue commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2051046753 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -171,7 +171,25 @@ public class TransactionManager { * *

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-15 Thread via GitHub
kirktrue commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2043388750 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -171,7 +171,25 @@ public class TransactionManager { * *

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-13 Thread via GitHub
chia7712 commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2041523678 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -171,7 +171,25 @@ public class TransactionManager { * *

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-11 Thread via GitHub
kirktrue commented on PR #19440: URL: https://github.com/apache/kafka/pull/19440#issuecomment-2798230694 Thanks @m1a2st! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-10 Thread via GitHub
kirktrue commented on PR #19440: URL: https://github.com/apache/kafka/pull/19440#issuecomment-2795209075 @jolshan—would you be willing to add the CI label so I can run the full test suite? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-10 Thread via GitHub
kirktrue opened a new pull request, #19440: URL: https://github.com/apache/kafka/pull/19440 Introduces a concrete subclass of `KafkaThread` named `SenderThread`. The poisoning of the TransactionManager on invalid state changes is determined by looking at the type of the current thread.