wcarlson5 merged PR #14619:
URL: https://github.com/apache/kafka/pull/14619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
wcarlson5 commented on PR #14619:
URL: https://github.com/apache/kafka/pull/14619#issuecomment-1787988965
The tests failing are not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375100926
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Softwar
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375100801
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375099944
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375100330
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375100148
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375100061
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375099869
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375099765
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Fo
xvrl commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375026123
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundati
xvrl commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375025585
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
xvrl commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375023475
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
xvrl commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1375018518
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
mjsax commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1374019186
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on PR #14619:
URL: https://github.com/apache/kafka/pull/14619#issuecomment-1776849161
Depends on PR - https://github.com/apache/kafka/pull/14575 for build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1369241432
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Softwar
AndrewJSchofield commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1369227989
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Softw
apoorvmittal10 opened a new pull request, #14619:
URL: https://github.com/apache/kafka/pull/14619
The PR defined the naming convention for telemetry metric names for KIP-714.
Telemetry metric name should be dot separated and tags should be snake case.
PR adds the interface which will
19 matches
Mail list logo
