jolshan merged PR #14627:
URL: https://github.com/apache/kafka/pull/14627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #14627:
URL: https://github.com/apache/kafka/pull/14627#issuecomment-1783457546
I will just watch the build now. Thanks @chb2ab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chb2ab commented on PR #14627:
URL: https://github.com/apache/kafka/pull/14627#issuecomment-1783399735
@jolshan np, I reverted that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
jolshan commented on PR #14627:
URL: https://github.com/apache/kafka/pull/14627#issuecomment-1783300697
@chb2ab sorry for the confusion. I realized that marking the version
unstable will probably cause issues if the ibp suggests using that version.
Since the tagged fields are the only diffe
jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373924152
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public
chb2ab commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373815620
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public s
chb2ab commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373814111
##
clients/src/main/resources/common/message/FetchRequest.json:
##
@@ -53,7 +53,9 @@
//
// Version 15 adds the ReplicaState which includes new field ReplicaEpoch
jolshan commented on PR #14627:
URL: https://github.com/apache/kafka/pull/14627#issuecomment-1781569023
I still need to go over the changes in #1. This would still probably be
faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373527381
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -102,6 +104,15 @@
"about": "The preferred read replica for the consumer to use on its
jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373518286
##
clients/src/main/resources/common/message/FetchRequest.json:
##
@@ -53,7 +53,9 @@
//
// Version 15 adds the ReplicaState which includes new field ReplicaEpoch
jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373516980
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public
chb2ab commented on PR #14627:
URL: https://github.com/apache/kafka/pull/14627#issuecomment-1781250666
I updated the title, this would be a partial implementation of KAFKA-15661.
I replied to the other comments as well and incorporated them into
https://github.com/apache/kafka/pull/14
12 matches
Mail list logo
