philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1380360543
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -1096,4 +1114,47 @@ private void subscribeInternal(Collection
dajac commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1380330986
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -1096,4 +1114,47 @@ private void subscribeInternal(Collection
top
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378452443
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -154,6 +158,8 @@ public class PrototypeAsyncConsumer implement
dajac commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1788027763
Does commitSync have the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dajac commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378159050
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -154,6 +158,8 @@ public class PrototypeAsyncConsumer implements
C
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378079473
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -384,12 +384,10 @@ public void commitAsync(Map offsets, Offset
kirktrue commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378071781
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -384,12 +384,10 @@ public void commitAsync(Map offsets, OffsetC