Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

dajac merged PR #14481: URL: https://github.com/apache/kafka/pull/14481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

dajac commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1403102326 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for the s

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429874 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429553 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429251 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429114 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401419710 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java: ## @@ -223,22 +223,13 @@ protected boolean racks

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401419710 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java: ## @@ -223,22 +223,13 @@ protected boolean racks

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401413975 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401404458 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401404039 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401401639 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401400649 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401397868 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401392351 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1401001513 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r140155 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400998694 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -96,7 +96,7 @@ public GroupAssignment assign( private

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400990586 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400980116 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,903 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400975524 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400884026 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

jeffkbkim commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400044251 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

jeffkbkim commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400045359 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

jeffkbkim commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1400044251 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1399989044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1399988448 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1397683148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

dajac commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1397600750 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for the s

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

dajac commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1397596576 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for the s

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396681253 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396679975 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396675130 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396672967 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396671729 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396670969 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396670619 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396669760 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396669104 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396667524 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396667524 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396639777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396638565 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396625136 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396624783 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396624092 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396618526 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396617558 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396614486 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396613887 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396612728 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396607932 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396596218 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396592116 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,891 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

jeffkbkim commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1396498916 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,828 @@ * See the License for t

Re: [PR] KAFKA-15484: General Rack Aware Assignor [kafka]

rreddy-22 commented on code in PR #14481: URL: https://github.com/apache/kafka/pull/14481#discussion_r1384454036 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -14,17 +14,828 @@ * See the License for t

[PR] KAFKA-15484/General Rack Aware Assignor [kafka]

rreddy-22 opened a new pull request, #14481: URL: https://github.com/apache/kafka/pull/14481 This is part two of the Uniform Assignor, used when the subscriptions of each member in a consumer group are different. Files added are: GeneralUniformAssignmentBuilder: Contains all the assign