Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2024-01-02 Thread via GitHub
ableegoldman commented on PR #14949: URL: https://github.com/apache/kafka/pull/14949#issuecomment-1874410202 Merged to trunk and cherrypicked to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2024-01-02 Thread via GitHub
ableegoldman merged PR #14949: URL: https://github.com/apache/kafka/pull/14949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2024-01-02 Thread via GitHub
ableegoldman commented on PR #14949: URL: https://github.com/apache/kafka/pull/14949#issuecomment-1874406419 FYI @agavra try to always fill out a PR description, even if it's super short/simple, so we have something for the commit message. I'll just make it up for this case but going forwar

Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2024-01-02 Thread via GitHub
ableegoldman commented on PR #14949: URL: https://github.com/apache/kafka/pull/14949#issuecomment-1874405243 Ok this has dragged on for long enough, I'm just going to merge this even though we haven't gotten a single individual run without any build failures, because (a) we have at least on

Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2023-12-19 Thread via GitHub
agavra commented on PR #14949: URL: https://github.com/apache/kafka/pull/14949#issuecomment-1863116184 @mjsax rebased - note that `trunk` had a "bug" where the latest PR added: ``` Streams API changes in 3.7.0 ``` even though it already existed, so I removed that line. -- This

Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2023-12-19 Thread via GitHub
mjsax commented on PR #14949: URL: https://github.com/apache/kafka/pull/14949#issuecomment-1862391991 @agavra -- PR need to be rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-15215: docs for KIP-954 [kafka]

2023-12-15 Thread via GitHub
ableegoldman commented on code in PR #14949: URL: https://github.com/apache/kafka/pull/14949#discussion_r1428577334 ## docs/streams/upgrade-guide.html: ## @@ -185,6 +185,13 @@ Streams API + +default.dsl.store was replaced with dsl.store.suppliers.class

[PR] KAFKA-15215: docs for KIP-954 [kafka]

2023-12-06 Thread via GitHub
agavra opened a new pull request, #14949: URL: https://github.com/apache/kafka/pull/14949 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai