showuon commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1862219804
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
tinaselenge commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1860352086
thanks @showuon, @nikramakrishnan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kamalcph commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428646042
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -926,16 +926,27 @@ private boolean
deleteLogSegmentsDueToLeaderEpochCacheTruncation(EpochEntry ear
showuon commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1858633479
There is a compilation failure in java 8 scala 12. Please help fix it.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14375/16/pipeline
--
This is
tinaselenge commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1857973003
@showuon thank you so much for reviewing the PR. I believe I address the
comments that I can. Please review again, when you get a chance. Thank you.
--
This is an automated message
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428034292
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3205,13 +3220,52 @@ class ReplicaManagerTest {
threadNamePrefix: Option[String],
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428033100
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3205,13 +3220,52 @@ class ReplicaManagerTest {
threadNamePrefix: Option[String],
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428033100
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3205,13 +3220,52 @@ class ReplicaManagerTest {
threadNamePrefix: Option[String],
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428032730
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -229,6 +229,9 @@ private Long buildRemoteLogAuxState(TopicPartition
topicPartition,
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428029820
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1042,8 +1053,9 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, Execut
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428029215
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3884,6 +3938,116 @@ class ReplicaManagerTest {
}
}
+ @Test
+ def testSuccessfu
showuon commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1855078026
Also, please resolve the conflict. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1426129619
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3205,13 +3220,52 @@ class ReplicaManagerTest {
threadNamePrefix: Option[String],
showuon commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1853767041
I'll take a look tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
clolov commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1780714845
I have republished KIP-963
(https://lists.apache.org/thread/40vsyc240hyody37mf2f0pn90shkzb45). Would
people manage to find some time to comment on it (@tinaselenge @nikramakrishnan
@showu
tinaselenge commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1772998045
thank you @clolov!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
clolov commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1772757204
Yup, I believe these metrics are useful and I will add them as part of
KIP-963, thanks for bringing this to my attention!
--
This is an automated message from the Apache Git Service.
To
tinaselenge commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1360770031
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -68,14 +68,15 @@
*/
public class ReplicaFetcherTierStateMachine implements TierStat
nikramakrishnan commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1358162028
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -229,6 +230,9 @@ private Long buildRemoteLogAuxState(TopicPartition
topicPartitio
nikramakrishnan commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1357082765
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -68,14 +68,16 @@
*/
public class ReplicaFetcherTierStateMachine implements Tier
nikramakrishnan commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1357082765
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -68,14 +68,16 @@
*/
public class ReplicaFetcherTierStateMachine implements Tier
21 matches
Mail list logo
