dajac merged PR #19515:
URL: https://github.com/apache/kafka/pull/19515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2085294443
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java:
##
@@ -52,13 +54,37 @@ public static class Builder extends
AbstractRequest.Builder
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2085263820
##
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##
@@ -1197,15 +1201,17 @@ class ConsumerProtocolMigrationTest(cluster:
ClusterInstance) ex
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2085262516
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -8349,23 +8377,168 @@ class KafkaApisTest extends Logging {
.setGroupId("group-4")
.
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2085256581
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -8269,6 +8276,7 @@ class KafkaApisTest extends Logging {
.setGroupId("group-1")
lianetm commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2084965325
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java:
##
@@ -52,13 +54,37 @@ public static class Builder extends
AbstractRequest.Builder
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2083987875
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java:
##
@@ -42,17 +43,21 @@ public void testWithMultipleGroups(short version) {
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2083979793
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java:
##
@@ -42,17 +43,21 @@ public void testWithMultipleGroups(short version) {
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2083796590
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java:
##
@@ -42,17 +43,21 @@ public void testWithMultipleGroups(short version) {
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2083791909
##
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java:
##
@@ -42,17 +43,21 @@ public void testWithMultipleGroups(short version) {
dajac commented on PR #19515:
URL: https://github.com/apache/kafka/pull/19515#issuecomment-2853466277
Opened https://github.com/apache/kafka/pull/19642.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on PR #19515:
URL: https://github.com/apache/kafka/pull/19515#issuecomment-2832570562
Opened https://github.com/apache/kafka/pull/19576.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on PR #19515:
URL: https://github.com/apache/kafka/pull/19515#issuecomment-2831932954
Opened https://github.com/apache/kafka/pull/19572.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on PR #19515:
URL: https://github.com/apache/kafka/pull/19515#issuecomment-2830819892
This PR is getting out of control because OffsetFetchRequest and
OffsetFetchResponse are way too complicated. I will simply them in separate PRs
and come back to this one afterwards.
--
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2059490597
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1043,13 +1045,33 @@ class KafkaApis(val requestChannel: RequestChannel,
offsetFetchResponse
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2059129776
##
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java:
##
@@ -629,8 +629,9 @@ private void
testAllMessageRoundTripsOffsetFetchFromVersionToV7(short f
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2059081281
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1834,6 +1834,44 @@ public void testFetchOffsetsWithUnknownGro
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2059080648
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1834,6 +1834,44 @@ public void testFetchOffsetsWithUnknownGro
dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2059077737
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1043,13 +1045,33 @@ class KafkaApis(val requestChannel: RequestChannel,
offsetFetchResponse
}
frankvicky commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2057673888
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java:
##
@@ -71,7 +72,8 @@ public Builder(String groupId,
boolea
dajac opened a new pull request, #19515:
URL: https://github.com/apache/kafka/pull/19515
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jir
21 matches
Mail list logo
