Re: [PR] KAFKA-14588 ConfigCommandTest rewritten in java [kafka]

2024-05-02 Thread via GitHub
chia7712 commented on PR #15839: URL: https://github.com/apache/kafka/pull/15839#issuecomment-2091799986 > I can try to move only subset of tests to make patches smaller. yep, that is good idea. Also, please try to migrate to the `ClusterTest`. I haven't dug in ConfigCommandTest, and

Re: [PR] KAFKA-14588 ConfigCommandTest rewritten in java [kafka]

2024-05-02 Thread via GitHub
nizhikov commented on PR #15839: URL: https://github.com/apache/kafka/pull/15839#issuecomment-2090657892 New tests passes on CI. PR ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-14588 ConfigCommandTest rewritten in java [kafka]

2024-05-02 Thread via GitHub
nizhikov commented on PR #15839: URL: https://github.com/apache/kafka/pull/15839#issuecomment-2090075317 Hello @chia7712 This is third part of KAFKA-14588. It contains huge `ConfigCommandTest` rewritten in java. I can try to move only subset of tests to make patches smaller.

[PR] KAFKA-14588 ConfigCommandTest rewritten in java [kafka]

2024-05-01 Thread via GitHub
nizhikov opened a new pull request, #15839: URL: https://github.com/apache/kafka/pull/15839 This is thirt part of https://github.com/apache/kafka/pull/15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains`ConfigCommandTest` rewritten in java ###