C0urante merged PR #12728:
URL: https://github.com/apache/kafka/pull/12728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1844822620
I have just pushed a merge commit which adds the
`testCreateConnectorWithStoppedInitialState()` test. The translation of the
test was quite straight forward, only thing to note is that
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1843872683
> @mdedetrich Thanks, the changes look good to go. But the build is failing
because there are new tests on trunk that still use EasyMock/PowerMock. Can you
rebase on the latest from tr
C0urante commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1843418398
@mdedetrich Thanks, the changes look good to go. But the build is failing
because there are new tests on trunk that still use EasyMock/PowerMock. Can you
rebase on the latest from trunk?
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1841940640
@C0urante @ijuma I have addressed the final comments, let me know if I have
missed anything
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1416539486
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -908,75 +799,58 @@ public void testCorruptConfig() thro
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1416535578
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -887,19 +783,14 @@ public void testPutConnectorConfig()
ijuma commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1840638490
@mdedetrich looks like this is really close - can you address the last set
of comments so we can merge?
--
This is an automated message from the Apache Git Service.
To respond to the mess
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1390091434
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -908,75 +799,58 @@ public void testCorruptConfig() throws
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1390087872
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -817,19 +726,14 @@ public void testAccessors() throws Exc
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1389230779
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -722,89 +646,68 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1389227114
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -656,48 +586,43 @@ public void testRestartConnectorAndT
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388621193
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -722,89 +646,68 @@ public void testRestartConnectorAndTas
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1389050516
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -838,39 +733,32 @@ public void testPutConnectorConfig()
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1389049719
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -838,39 +733,32 @@ public void testPutConnectorConfig()
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1389047935
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -817,19 +731,11 @@ public void testAccessors() throws E
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388623720
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -656,48 +586,43 @@ public void testRestartConnectorAndTas
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388627971
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -838,39 +733,32 @@ public void testPutConnectorConfig() t
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388621758
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -817,19 +731,11 @@ public void testAccessors() throws Exc
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388621193
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -722,89 +646,68 @@ public void testRestartConnectorAndTas
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1801718171
@C0urante So I can confirm the following things
* No methods are directly called on mocks (I checked both mocks defined by
the `@Mock` annotation or local mocks created with `moc
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1795695928
Will do, I just removed the other `herder::onRestart` and I forgot about the
rest of the instances of `atLeastOnce()` (they are now all gone).
Ill try and go through the tests on
C0urante commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1795622577
@mdedetrich It looks like there's still a direct call to `herder::onRestart`
in the `testRestartConnectorAndTasksOnlyTasks` test.
Can you please revisit the PR, reviewing every tes
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1795575391
@C0urante Gone through all of your comments/remarks and the tests pass, let
me know if anything additional is needed
--
This is an automated message from the Apache Git Service.
To r
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383701619
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -127,94 +134,86 @@ private enum SourceSink {
n
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383700349
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -223,93 +216,81 @@ public void testCreateConnectorAlrea
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383698647
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -1256,4 +1120,11 @@ private abstract class BogusSinkCon
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383698000
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,61 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383692832
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,61 @@ public void testRestartConnectorAndT
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383690782
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -223,93 +216,81 @@ public void testCreateConnectorAlready
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1383657133
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,61 @@ public void testRestartConnectorAndTas
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1382163078
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,61 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1382134025
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -281,45 +274,38 @@ public void testDestroyConnector() t
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1382133745
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -127,94 +134,86 @@ private enum SourceSink {
n
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1378185193
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -281,45 +274,38 @@ public void testDestroyConnector() t
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1377879325
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -281,45 +274,38 @@ public void testDestroyConnector() thr
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376569126
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -602,36 +546,37 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376522158
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -127,94 +134,86 @@ private enum SourceSink {
n
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376517329
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -281,45 +274,38 @@ public void testDestroyConnector() t
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376516820
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -281,45 +274,38 @@ public void testDestroyConnector() t
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376517843
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -127,94 +134,86 @@ private enum SourceSink {
n
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376493619
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -656,48 +600,40 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376484462
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -602,36 +546,37 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376483865
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,61 @@ public void testRestartConnectorAndT
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1376416990
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,61 @@ public void testRestartConnectorAndTas
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374442966
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -127,94 +134,86 @@ private enum SourceSink {
n
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374443260
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -817,19 +731,11 @@ public void testAccessors() throws E
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374442341
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -838,39 +744,33 @@ public void testPutConnectorConfig()
mimaison commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374348110
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -127,94 +134,86 @@ private enum SourceSink {
non
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374168471
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -617,8 +616,7 @@ public void testRestartConnectorAndTas
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1782422797
@C0urante Commit pushed resolving your latest comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374165166
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374163842
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374138454
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374136601
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374136601
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1373831428
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndTas
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1373830704
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndTas
ijuma commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1779282256
@mimaison Do you have the cycles to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1779161332
@mimaison @ijuma I have just finished PR and I can confirm the tests are
passing locally. Due to the fact we are no longer dealing with static classes,
the setting up of the static moc
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1775892079
@mimaison I started rebasing across `trunk` and under-estimated the amount
of changes that have since landed so this may take a day or two longer
--
This is an automated message from
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1773039378
> @mdedetrich Sorry I just notice now that I was "can _we_ rebase", I meant
"can _you_ rebase". If you're not able to complete this PR, let me know.
I'll have it done by Monday
mimaison commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1772979943
@mdedetrich Sorry I just notice now that I was "can _we_ rebase", I meant
"can _you_ rebase". If you're not able to complete this PR, let me know.
--
This is an automated message from
ijuma commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1766441852
It would be nice to get this over the line. It's one of only 3 tests that
are excluded when we run with Java 17 or 21.
--
This is an automated message from the Apache Git Service.
To resp
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1764446152
> @mdedetrich Can we rebase on trunk to resolve the conflicts? Thanks
Of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mimaison commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1764076510
@mdedetrich Can we rebase on trunk to resolve the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
66 matches
Mail list logo
