Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-02-05 Thread via GitHub
cadonna commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1943069285 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToCloseC

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-02-03 Thread via GitHub
eduwercamacaro commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1939718078 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksT

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-01-29 Thread via GitHub
cadonna commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1933528869 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToCloseC

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-01-23 Thread via GitHub
ableegoldman commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1927963266 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToC

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-01-23 Thread via GitHub
mjsax commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1927659866 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToCloseCle

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2025-01-22 Thread via GitHub
ableegoldman commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1926229352 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToC

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2024-12-25 Thread via GitHub
fonsdant commented on PR #17761: URL: https://github.com/apache/kafka/pull/17761#issuecomment-2562084069 @eduwercamacaro, spotlessJavaCheck has failed. We need to apply its code suggestions to fix the build. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2024-11-15 Thread via GitHub
eduwercamacaro commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1843953394 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksT

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2024-11-13 Thread via GitHub
mjsax commented on code in PR #17761: URL: https://github.com/apache/kafka/pull/17761#discussion_r1841464654 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -731,15 +732,20 @@ private void addToTasksToClose(final Map tasksToCloseCle

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2024-11-13 Thread via GitHub
eduwercamacaro commented on PR #17761: URL: https://github.com/apache/kafka/pull/17761#issuecomment-2473986471 Pinging @cadonna @mjsax @ableegoldman for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2024-11-11 Thread via GitHub
eduwercamacaro opened a new pull request, #17761: URL: https://github.com/apache/kafka/pull/17761 Tasks that are registered in the state updater could raise an exception during the restoration process, for example a consumer timeout exception, a task corrupted, or any other StreamsException